Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wagmi + viem #1404

Merged
merged 4 commits into from
Jan 31, 2025
Merged

feat: add wagmi + viem #1404

merged 4 commits into from
Jan 31, 2025

Conversation

dohaki
Copy link
Contributor

@dohaki dohaki commented Jan 29, 2025

Closes ACX-3682

  • Adds wagmi and viem
  • Enhances helper scripts to support initialization of wagmi

Note that this PR is just a prerequisite for the upcoming custom wallet UI work. This doesn't break anything nor does it introduce user-facing functionality or changes.

Copy link

linear bot commented Jan 29, 2025

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 4:19am
sepolia-frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 4:19am

Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the goal to eventually move off of Ethers/onboard?

james-a-morris
james-a-morris previously approved these changes Jan 29, 2025
@dohaki
Copy link
Contributor Author

dohaki commented Jan 29, 2025

Is the goal to eventually move off of Ethers/onboard?

Eventually, yes. But with our custom wallet UI in mind, we should probably do a staged approach:

  1. Move off onboard and use wagmi: Wagmi can still be used with ethers. So in this stage we don't need to migrate to viem yet.
  2. Move off ethers and use viem

Copy link
Contributor

@gsteenkamp89 gsteenkamp89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I like that we're not throwing out ethers in this PR just yet. Your comment about a staged approach seems logical to me.

@dohaki dohaki merged commit 359e919 into master Jan 31, 2025
9 checks passed
@dohaki dohaki deleted the add-viem-wagmi branch January 31, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants