-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add wagmi + viem #1404
feat: add wagmi + viem #1404
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the goal to eventually move off of Ethers/onboard?
Eventually, yes. But with our custom wallet UI in mind, we should probably do a staged approach:
|
61c0418
to
9b2b343
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I like that we're not throwing out ethers in this PR just yet. Your comment about a staged approach seems logical to me.
Closes ACX-3682
Note that this PR is just a prerequisite for the upcoming custom wallet UI work. This doesn't break anything nor does it introduce user-facing functionality or changes.