fix(constants): Bump default fillDeadline 2.5 -> 3.25 hours #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.5 hours has proven to be a little bit too tight. So far there have been 3 large deposits that timed out shortly before slow fills could be executed. Analysis of these fills shows that even 3 hours would have been tight (but not impossible). Conservatively default to 3.25 hours instead. To be updated in the event that dart request a different number.
pxrl
requested review from
mrice32,
nicholaspai,
dohaki and
james-a-morris
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dohaki
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.5 hours has proven to be a little bit too tight. So far there have been 3 large deposits that timed out shortly before slow fills could be executed. Analysis of these fills shows that even 3 hours would have been tight (but not impossible). Conservatively default to 3.25 hours instead. To be updated in the event that dart request a different number.