-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix REPLACE
function with replace patterns
#1755
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1755 +/- ##
==========================================
+ Coverage 89.98% 90.01% +0.02%
==========================================
Files 395 395
Lines 37693 37779 +86
Branches 4241 4256 +15
==========================================
+ Hits 33919 34005 +86
Misses 2478 2478
Partials 1296 1296 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left two and a half comments, that should be easy to address.
Conformance check passed ✅Test Status Changes 📊
|
|
In the replace string of the
REPLACE
function, QLever now uses a dollar sign$
to dynamically fetch the replacement from the input. For exampleREPLACE("aabc", "(a+)b", "$1def$1")
will now correctly result in "aadefaac".This fix is implemented by manually converting the replacement string to the format the Google RE2 expects where the replacement format is not
$n
but\n
.Fixes #1664