Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CONSTRUCT WHERE correctly #1757

Merged
merged 13 commits into from
Feb 6, 2025

Conversation

RobinTF
Copy link
Collaborator

@RobinTF RobinTF commented Feb 4, 2025

Queries such as CONSTRUCT WHERE { ?s ?p ?o} are now correctly treated equivalently to CONSTRUCT { ?s ?p ?o} WHERE { ?s ?p ?o}. Previously they returned an empty result because they were evaluated like CONSTRUCT {} WHERE {?s ?p ?o}
Fixes #1349

@RobinTF RobinTF marked this pull request as ready for review February 4, 2025 18:07
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.02%. Comparing base (098b79c) to head (11dd6f3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1757      +/-   ##
==========================================
+ Coverage   90.01%   90.02%   +0.01%     
==========================================
  Files         395      395              
  Lines       37793    37838      +45     
  Branches     4257     4258       +1     
==========================================
+ Hits        34019    34064      +45     
  Misses       2478     2478              
  Partials     1296     1296              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much,
I have some small questions, but the approach is rather clean and not too intrusive

src/parser/sparqlParser/SparqlQleverVisitor.cpp Outdated Show resolved Hide resolved
src/parser/sparqlParser/SparqlQleverVisitor.cpp Outdated Show resolved Hide resolved
src/parser/sparqlParser/SparqlQleverVisitor.cpp Outdated Show resolved Hide resolved
src/parser/sparqlParser/SparqlQleverVisitor.cpp Outdated Show resolved Hide resolved
src/parser/sparqlParser/SparqlQleverVisitor.cpp Outdated Show resolved Hide resolved
src/parser/sparqlParser/SparqlQleverVisitor.h Outdated Show resolved Hide resolved
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a very minor suggestion remaining, is quick to fix.

src/parser/sparqlParser/SparqlQleverVisitor.cpp Outdated Show resolved Hide resolved
src/parser/sparqlParser/SparqlQleverVisitor.cpp Outdated Show resolved Hide resolved
@sparql-conformance
Copy link

Conformance check passed ✅

Test Status Changes 📊

Number of Tests Previous Status Current Status
4 Failed Passed

Details: https://qlever.cs.uni-freiburg.de/sparql-conformance-ui?cur=11dd6f3247568d5daeeb9ba049f6f68697a80403&prev=098b79c715f9992972a8d3452f5bd10e303c6ce4

Copy link

sonarqubecloud bot commented Feb 5, 2025

@joka921 joka921 changed the title Correct WHERE parsing for CONSTRUCT WHERE Implement CONSTRUCT WHERE correctly Feb 6, 2025
Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much

@joka921 joka921 merged commit a307781 into ad-freiburg:master Feb 6, 2025
24 checks passed
@RobinTF RobinTF deleted the fix-construct-patterns branch February 6, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CONSTRUCT WHERE is not supported
2 participants