-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CONSTRUCT WHERE
correctly
#1757
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1757 +/- ##
==========================================
+ Coverage 90.01% 90.02% +0.01%
==========================================
Files 395 395
Lines 37793 37838 +45
Branches 4257 4258 +1
==========================================
+ Hits 34019 34064 +45
Misses 2478 2478
Partials 1296 1296 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much,
I have some small questions, but the approach is rather clean and not too intrusive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a very minor suggestion remaining, is quick to fix.
Conformance check passed ✅Test Status Changes 📊
|
|
CONSTRUCT WHERE
correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much
Queries such as
CONSTRUCT WHERE { ?s ?p ?o}
are now correctly treated equivalently toCONSTRUCT { ?s ?p ?o} WHERE { ?s ?p ?o}
. Previously they returned an empty result because they were evaluated likeCONSTRUCT {} WHERE {?s ?p ?o}
Fixes #1349