Unescape Unicode sequences in the SPARQL parser #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinTF
force-pushed
the
implement-utf-8-pre-parsing
branch
from
30f7865 to
f42bdf1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1770 +/- ##
==========================================
+ Coverage 90.00% 90.01% +0.01%
==========================================
Files 395 395
Lines 37838 37904 +66
Branches 4258 4263 +5
==========================================
+ Hits 34055 34120 +65
- Misses 2484 2486 +2
+ Partials 1299 1298 -1 ☔ View full report in Codecov by Sentry. |
Conformance check passed ✅Test Status Changes 📊
|
|
joka921
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure escape sequences are applied before passing the string to ANTLR for the real parsing step (see the SPARQL 1.1 specification for details). UTF-16 surrogate pairs are correctly handled. Also the ctre version is incremented to use
search_all(non-deprecated variant ofrange).