Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add scoreAsPercent to help text, remove unnecessary triple squigglies (fixes #82) #84

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

swashbuck
Copy link
Contributor

Fixes #82

Fix

  • Adds scoreAsPercent to the help text in the schemas
  • Removes triple squigglies from the schemas where it is unlikely to be used. For instance, there should generally not be a need to allow HTML tags in maxScore, so we can just recommend using double squigglies. This also aligns with the instructions in the readme.

@swashbuck swashbuck added the bug label Mar 4, 2024
@swashbuck swashbuck self-assigned this Mar 4, 2024
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@swashbuck swashbuck merged commit 5ba4d1d into master Mar 5, 2024
1 check passed
@swashbuck swashbuck deleted the issue/82 branch March 5, 2024 16:56
Copy link

github-actions bot commented Mar 5, 2024

🎉 This PR is included in version 5.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variables in help text
4 participants