New: Separate .is-locked and .is-disabled btn state classes #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirsty-hames
changed the title
|
After discussion, instead of separating state classes, locking state to be added to disabled buttons. This removes the dependency from Vanilla PR, add drawer item locked state. PR to be updated to reflect. |
kirsty-hames
deleted the
separating-locked-from-inactive-disabled-buttons
branch
|
🎉 This PR is included in version 7.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to Core issue to allow for locked and inactive disabled buttons to be visually different.
Depending on the button context, the appropriate
.is-lockedor.is-disabledclasses should be used..is-locked- applies to buttons that are temporarily disabled due to step locked content..is-disabled- applies to buttons with functionality not available. Styles are inherited from Vanilla less/core/drawerItem.less.#### Dependencies
.is-lockedstyles require Vanilla PR, add drawer item locked state.Update: Dependency removed in 6dbfcad.
After discussion, instead of separating state classes,
.is-lockedhas been added in addition to.is-disabled. This removes the dependency from Vanilla PR, add drawer item locked state as earlier versions of Vanilla will still inherit.is-disabledstyles.Testing PR example
In your course, navigate to Adapt Assessment. Open PLP drawer and inspect. Trickled items,
.pagelevelprogress__item-btnshould have the classes.is-disabled .is-locked.In the same course, set a component to
"_isVisible": false,. Navigate to this component, open PLP drawer and inspect. The hidden component,.pagelevelprogress__item-btnshould have the class.is-disabled.