Skip to content

Commit

Permalink
Resolves #2247, adds support for editing 'identifier' attribute (#182)
Browse files Browse the repository at this point in the history
Some LMSs are picky with regards to the identifier used in imsmanifest.xml so
this is now a configurable option, defaulted to 'adapt_manifest' (as is).

- Updated properties.schema, bower.json and README.md.
- Minimum framework version bumped to 3.5.0 to allow support for custom identifier in imsmanifest.xml.
- Version bump to 3.2.0
  • Loading branch information
brian-learningpool authored Feb 7, 2019
1 parent c484b20 commit 3514a1d
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 5 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ Note that due to the data storage limitations of browser cookies, there is less
Currently (officially) only supports SCORM 1.2

----------------------------
**Version number:** 3.1.0 <a href="https://community.adaptlearning.org/" target="_blank"><img src="https://github.com/adaptlearning/documentation/blob/master/04_wiki_assets/plug-ins/images/adapt-logo-mrgn-lft.jpg" alt="adapt learning logo" align="right"></a>
**Framework versions:** 3.0.0+
**Version number:** 3.2.0 <a href="https://community.adaptlearning.org/" target="_blank"><img src="https://github.com/adaptlearning/documentation/blob/master/04_wiki_assets/plug-ins/images/adapt-logo-mrgn-lft.jpg" alt="adapt learning logo" align="right"></a>
**Framework versions:** 3.5.0+
**Author / maintainer:** Adapt Core Team with [contributors](https://github.com/adaptlearning/adapt-contrib-spoor/graphs/contributors)
**Accessibility support:** n/a
**RTL support:** n/a
Expand Down
4 changes: 2 additions & 2 deletions bower.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "adapt-contrib-spoor",
"version": "3.1.0",
"framework": ">=3",
"version": "3.2.0",
"framework": ">=3.5.0",
"homepage": "https://github.com/adaptlearning/adapt-contrib-spoor",
"issues": "https://github.com/adaptlearning/adapt_framework/issues/new",
"displayName" : "Spoor",
Expand Down
9 changes: 9 additions & 0 deletions properties.schema
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,15 @@
"inputType": "Checkbox",
"validators": [],
"help": "If enabled, a 'commit' call will be made whenever the course window is hidden/minimised. Requires a browser that supports the 'visibilitychange' event."
},
"_manifestIdentifier": {
"type": "string",
"required": true,
"default": "adapt_manifest",
"title": "Manifest identifier",
"inputType": "Text",
"validators": ["required"],
"help": "Sets the 'identifier' attribute in the imsmanifest.xml"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion required/imsmanifest.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<manifest identifier="adapt_manifest" version="1" xmlns="http://www.imsproject.org/xsd/imscp_rootv1p1p2" xmlns:adlcp="http://www.adlnet.org/xsd/adlcp_rootv1p2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.imsproject.org/xsd/imscp_rootv1p1p2 imscp_rootv1p1p2.xsd http://www.imsglobal.org/xsd/imsmd_rootv1p2p1 imsmd_rootv1p2p1.xsd http://www.adlnet.org/xsd/adlcp_rootv1p2 adlcp_rootv1p2.xsd">
<manifest identifier="@@config._spoor._advancedSettings._manifestIdentifier" version="1" xmlns="http://www.imsproject.org/xsd/imscp_rootv1p1p2" xmlns:adlcp="http://www.adlnet.org/xsd/adlcp_rootv1p2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.imsproject.org/xsd/imscp_rootv1p1p2 imscp_rootv1p1p2.xsd http://www.imsglobal.org/xsd/imsmd_rootv1p2p1 imsmd_rootv1p2p1.xsd http://www.adlnet.org/xsd/adlcp_rootv1p2 adlcp_rootv1p2.xsd">
<metadata>
<schema>ADL SCORM</schema>
<schemaversion>1.2</schemaversion>
Expand Down

0 comments on commit 3514a1d

Please sign in to comment.