Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/config: include remote configuration files #96

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

seilagamo
Copy link
Collaborator

This PR build a Direct Acyclic Graph while is discovering the includes in the configuration files recursively.

This PR DOES NOT merge the configurations yet.

Note that this PR is strongly inspired by https://github.com/KyleBanks/depth.

internal/config/config.go Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
internal/dag/dag.go Outdated Show resolved Hide resolved
internal/dag/dag.go Outdated Show resolved Hide resolved
internal/dag/dag.go Outdated Show resolved Hide resolved
internal/dag/dag.go Outdated Show resolved Hide resolved
internal/dag/dag.go Outdated Show resolved Hide resolved
internal/dag/dag.go Outdated Show resolved Hide resolved
internal/config/include.go Outdated Show resolved Hide resolved
internal/config/include.go Outdated Show resolved Hide resolved
@seilagamo seilagamo force-pushed the include-remote-config branch 9 times, most recently from 332f94d to 422862c Compare January 17, 2025 11:37
@seilagamo seilagamo requested a review from jroimartin January 17, 2025 11:44
.github/workflows/golangci-lint.yaml Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
internal/config/dag/dag.go Outdated Show resolved Hide resolved
internal/config/dag/dag.go Outdated Show resolved Hide resolved
internal/config/dag/dag.go Outdated Show resolved Hide resolved
internal/engine/engine.go Outdated Show resolved Hide resolved
internal/config/resolver.go Outdated Show resolved Hide resolved
internal/config/resolver.go Outdated Show resolved Hide resolved
internal/config/resolver.go Outdated Show resolved Hide resolved
internal/config/resolver.go Outdated Show resolved Hide resolved
@seilagamo seilagamo force-pushed the include-remote-config branch 2 times, most recently from d596766 to 5f1ae5a Compare January 23, 2025 11:02
@seilagamo seilagamo requested a review from jroimartin January 23, 2025 11:09
internal/config/configgraph.go Outdated Show resolved Hide resolved
.github/workflows/golangci-lint.yaml Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
internal/config/config.go Outdated Show resolved Hide resolved
internal/config/dag/dag_test.go Show resolved Hide resolved
internal/config/configgraph.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jroimartin jroimartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Just one last nitpick.

internal/config/config.go Outdated Show resolved Hide resolved
@seilagamo seilagamo requested a review from jroimartin January 23, 2025 15:58
Copy link
Contributor

@jroimartin jroimartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean up commit history.

@seilagamo seilagamo force-pushed the include-remote-config branch from 57a489d to ceb964f Compare January 23, 2025 16:02
@seilagamo seilagamo merged commit 63528d3 into main Jan 23, 2025
6 checks passed
@seilagamo seilagamo deleted the include-remote-config branch January 23, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants