-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/config: include remote configuration files #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seilagamo
force-pushed
the
include-remote-config
branch
from
September 19, 2024 14:27
ec7c67c
to
3a1d9cf
Compare
jroimartin
requested changes
Jan 14, 2025
seilagamo
force-pushed
the
include-remote-config
branch
9 times, most recently
from
January 17, 2025 11:37
332f94d
to
422862c
Compare
jroimartin
requested changes
Jan 17, 2025
jroimartin
reviewed
Jan 17, 2025
seilagamo
force-pushed
the
include-remote-config
branch
2 times, most recently
from
January 23, 2025 11:02
d596766
to
5f1ae5a
Compare
jroimartin
requested changes
Jan 23, 2025
jroimartin
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Just one last nitpick.
jroimartin
approved these changes
Jan 23, 2025
jroimartin
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Clean up commit history.
seilagamo
force-pushed
the
include-remote-config
branch
from
January 23, 2025 16:02
57a489d
to
ceb964f
Compare
jroimartin
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR build a Direct Acyclic Graph while is discovering the includes in the configuration files recursively.
This PR DOES NOT merge the configurations yet.
Note that this PR is strongly inspired by https://github.com/KyleBanks/depth.