Fix RegistryAuthenticator filesystem #65
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RegistryAuthenticator was initializated with a mock of filesystem instead of OS filesystem.
This prevented to use containerd support.
Registry instances RegistryAuthenticator with a filesystem.
This filesystem is being used here:
https://github.com/adevinta/noe/blob/main/pkg/registry/login.go#L124
To walk over:
https://github.com/adevinta/noe/blob/main/pkg/registry/login.go#L217
As the filesystem is being mocked, it wont walk over the directory and it wont be able to use containerd.
Once this is solved merging this PR you would find this type of logs:
https://github.com/adevinta/noe/blob/main/pkg/registry/login.go#L150