NOJIRA Break PodReconciler.Reconcile() into helpers #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Context The `PodReconciler.Reconcile()` is long and convoluted, making it hard to understand and parse. As there are distinct steps in its operation, let's break them into helpers named after the logical operation to simplify understanding it. # What this changes - Extract interface for caching and platform statistics into its own private methods, starting a new internal API. - Group all the code required to determine if an existing Pod is already scheduled properly into its own private method. - Streamline the main method's flow to reduce indentation and clarify the logical process. # Non-goals - Modify the behaviour of the reconcile method Change-Id: Id39d5caf4120b1f20a138b6dfecd5ae8be344eab
joaoqalves
requested changes
Jan 8, 2024
Co-authored-by: João Alves <[email protected]>
Co-authored-by: João Alves <[email protected]>
Co-authored-by: João Alves <[email protected]>
Co-authored-by: João Alves <[email protected]>
joaoqalves
approved these changes
Jan 8, 2024
miguelbernadi
commented
Jan 8, 2024
miguelbernadi
commented
Jan 8, 2024
Fsero
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The
PodReconciler.Reconcile()is long and convoluted, making it hard to understand and parse. As there are distinct steps in its operation, let's break them into helpers named after the logical operation to simplify understanding it.What this changes
Extract interface for caching and platform statistics into its own private methods, starting a new internal API.
Group all the code required to determine if an existing Pod is already scheduled properly into its own private method.
Streamline the main method's flow to reduce indentation and clarify the logical process.
Non-goals
Change-Id: Id39d5caf4120b1f20a138b6dfecd5ae8be344eab