Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump flyway #30

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Bump flyway #30

merged 6 commits into from
Mar 21, 2024

Conversation

jesusfcr
Copy link
Contributor

No description provided.

@jesusfcr jesusfcr force-pushed the multi-gitter-flyway branch from 10990e9 to f978fd6 Compare March 19, 2024 13:22
@jesusfcr jesusfcr force-pushed the multi-gitter-flyway branch from f978fd6 to 75da994 Compare March 20, 2024 16:35
@@ -2,5 +2,5 @@

# Copyright 2023 Adevinta

docker run --net=host flyway/flyway:"${FLYWAY_VERSION:-9.19.4}-alpine" -community \
docker run --net=host flyway/flyway:"${FLYWAY_VERSION:-9.19.4}-alpine" \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should the old version continue to be used as fallback?

@@ -9,5 +9,5 @@ docker exec vultrackerdb psql -c "ALTER USER vultrackerdb_test WITH SUPERUSER;"
docker exec vultrackerdb psql -c "CREATE DATABASE vultrackerdb_test;" -U vultrackerdb


docker run --net=host --rm -v "$PWD"/sql:/flyway/sql flyway/flyway:"${FLYWAY_VERSION:-9.19.4}-alpine" -community \
docker run --net=host --rm -v "$PWD"/sql:/flyway/sql flyway/flyway:"${FLYWAY_VERSION:-9.19.4}-alpine" \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

Copy link
Collaborator

@seilagamo seilagamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesusfcr jesusfcr merged commit aac916a into master Mar 21, 2024
2 checks passed
@jesusfcr jesusfcr deleted the multi-gitter-flyway branch April 2, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants