Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): accept available placeholders as json list #884

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

winged
Copy link
Member

@winged winged commented Nov 12, 2024

Instead of multiple fields with the same name (traditional form-data
lists), we also accept a JSON list for the available placeholders. This
helps reduce the number of fields in the request, which WAF, Django, and
possibly other server-side web components don't appreciate.

docker compose doesn't want those fields anymore
@winged winged requested a review from luytena November 12, 2024 14:24
Instead of multiple fields with the same name (traditional form-data
lists), we also accept a JSON list for the available placeholders. This
helps reduce the number of fields in the request, which WAF, Django, and
possibly other server-side web components don't appreciate.
@winged winged force-pushed the accept_placeholders_json branch from ae615b2 to 88887c4 Compare November 12, 2024 14:26
Copy link
Contributor

@luytena luytena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@winged winged merged commit 1ae2769 into adfinis:main Nov 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants