-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kubernetes-etcd-backup): s3 support for kubernetes etcd backups #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Nov 25, 2024
hairmare
changed the title
feat(): s3 support for kubernetes etcd backups
feat(kubernetes-etcd-backup): s3 support for kubernetes etcd backups
Nov 25, 2024
@norbertgruszka looks good, but can you fix the CI? |
@vmaillot CI Fix, the PR is ready for merge |
vmaillot
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for s3 storage in Kubernetes etcd backup job
Issues
adfinis/kubernetes-etcd-backup#22
Checklist
artifacthub.io/changes
annotation inChart.yaml
, check the example in the documentation.pre-commit run
docs/
Related PRs
adfinis/kubernetes-etcd-backup#25