Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kubernetes-etcd-backup): s3 support for kubernetes etcd backups #1341

Merged
merged 11 commits into from
Jan 10, 2025

Conversation

norbertgruszka
Copy link
Contributor

@norbertgruszka norbertgruszka commented Nov 25, 2024

Description

Add support for s3 storage in Kubernetes etcd backup job

Issues

adfinis/kubernetes-etcd-backup#22

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

Related PRs

adfinis/kubernetes-etcd-backup#25

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 25, 2024
@hairmare hairmare changed the title feat(): s3 support for kubernetes etcd backups feat(kubernetes-etcd-backup): s3 support for kubernetes etcd backups Nov 25, 2024
@norbertgruszka norbertgruszka marked this pull request as ready for review December 23, 2024 13:36
@norbertgruszka norbertgruszka requested a review from a team as a code owner December 23, 2024 13:36
@vmaillot
Copy link
Contributor

@norbertgruszka looks good, but can you fix the CI?

@norbertgruszka norbertgruszka enabled auto-merge (squash) January 10, 2025 08:24
@norbertgruszka
Copy link
Contributor Author

@vmaillot CI Fix, the PR is ready for merge

@norbertgruszka norbertgruszka merged commit e404bca into main Jan 10, 2025
3 checks passed
@norbertgruszka norbertgruszka deleted the feat/k8s-etcd-backup-s3 branch January 10, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants