Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the rpm build, broken by bad configuration and missing package install #126

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Fix the rpm build, broken by bad configuration and missing package install #126

merged 2 commits into from
Jan 8, 2025

Conversation

Melkor333
Copy link
Contributor

@Melkor333 Melkor333 commented Jan 8, 2025 •
edited
Loading

types-jsonschema is only a dev-dependency and python3-jsonschema needs to be added to the list of packages to be installed to create the rpm.
The version for jsonschema also needs to be lower, as rhel don't have version 4.23 packaged. Thus the requirement of 4.0 should be enough.

@Melkor333
fix: FIx schema min dep and move types to dev
bfec92f 
Allow jsonschema 4.0.0 since distros have old versions.
Also move types-jsonschema to dev deps.
@Melkor333
build: install jsonschema when building the rpm
ec80fba
@Melkor333 Melkor333 requested a review from winged January 8, 2025 11:46
winged
winged approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@winged winged merged commit 3c6fcc6 into main Jan 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winged winged winged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Melkor333 @winged