Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: convert package and serverless plugin to typescript #39

Open
adieuadieu opened this issue Jul 12, 2017 · 3 comments · May be fixed by #205
Open

Feat: convert package and serverless plugin to typescript #39

adieuadieu opened this issue Jul 12, 2017 · 3 comments · May be fixed by #205
Assignees
Milestone

Comments

@adieuadieu
Copy link
Owner

adieuadieu commented Jul 12, 2017

Convert the serverless plugin and standalone package to typescript. Tests, too? However, not the examples.

@adieuadieu adieuadieu self-assigned this Jul 12, 2017
@adieuadieu adieuadieu added this to the 1.1 milestone Jul 15, 2017
@md97212
Copy link

md97212 commented Oct 24, 2017

Is this where you where working on this Feature? integration-test/typescript-handler.ts

Is the crux just including the definitions file? or is it more than that? I was looking at this, got stuck in the same spot and then found your example :)

@adieuadieu
Copy link
Owner Author

Hi @md97212 — Hm.. integration-test/typescript-handler.ts is just a test file to make sure that the serverless-plugin-chrome package plays well with the serverless-plugin-typescript plugin.

The goal of this Issue is to convert all of the Javascript in the two packages (~/packages/lambda and ~/packages/serverless-plugin) to Typescript. It's blocked until 1.0 is released (see #74).

@mooyoul
Copy link

mooyoul commented Dec 10, 2017

If you guys interested in typescript definition for typescript-based project. Please checkout our serverless-chrome typescript definition file

@mooyoul mooyoul linked a pull request May 20, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment