Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/typescript #205

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Refactor/typescript #205

wants to merge 4 commits into from

Conversation

mooyoul
Copy link

@mooyoul mooyoul commented May 20, 2019 •
edited
Loading

Breaking changes

  • Drop nodejs6.10 runtime support
  • Remove DEBUG environment usage
    Currently, There are no way to enable debug logs without disabling debug mode of serverless-chrome due to conflict of environment name.
  • Remove user profile related setup/teardown steps
    IMO user should take responsibility of custom behaviors like this case.

Changes

  • Migrate @serverless/package code to Typescript
  • Remove built-in logger, migrate debugging-related logging to use debug package.
  • Fixed unsafe/unhandled async operations

Fixes #39, #92, #168, #175, #178, #186, #197 also.

@mooyoul mooyoul requested a review from adieuadieu May 20, 2019 19:05
@adieuadieu adieuadieu changed the base branch from master to develop January 20, 2020 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adieuadieu adieuadieu Awaiting requested review from adieuadieu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: convert package and serverless plugin to typescript
1 participant
@mooyoul