Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regular expression for quoted values in parentheses (+ add test) #400

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JorianWoltjer
Copy link

Description

As explained in the related issue, values with parentheses should allow quoted strings inside where a closing parathesis is part of the string. This wasn't the case with the regex before, and I've added this extra case to the regex. Visualized, here is the before and after:

Before After
image (2) image (1)

Related Issue

#399

Motivation and Context

In some real-world CSS files, such quoted strings contain ) characters that would cause the parser to crash or read on silently capturing tens of thousands of random CSS bytes as the string value. See the related issue for more details.

How Has This Been Tested?

2 tests were added to the quoted test case:

  background: url('more stuff); here') 50% 50% no-repeat;
  background: url(https://example.com/a;b) 50% 50% no-repeat;

The first is for the initial issue, and the second is to make sure semicolons are still allowed within parentheses.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant