Fix regular expression for quoted values in parentheses (+ add test) #400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As explained in the related issue, values with parentheses should allow quoted strings inside where a closing parathesis is part of the string. This wasn't the case with the regex before, and I've added this extra case to the regex. Visualized, here is the before and after:
Related Issue
#399
Motivation and Context
In some real-world CSS files, such quoted strings contain
)
characters that would cause the parser to crash or read on silently capturing tens of thousands of random CSS bytes as the string value. See the related issue for more details.How Has This Been Tested?
2 tests were added to the
quoted
test case:The first is for the initial issue, and the second is to make sure semicolons are still allowed within parentheses.
Types of changes
Checklist: