-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dayperiod segment no longer resets when hour deleted #7506
fix: dayperiod segment no longer resets when hour deleted #7506
Conversation
Thanks for the PR! It seems like you've run prettier or something similar over the file which has created a lot of noise and fails lint. Would you mind undoing that so it's easier to review the actual change? |
Sorry about that @yihuiliao ! I think I got that fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the wait! The changes look good, I just added a test which I hope you don't mind. I'll get others to review but thanks for being patient!
Thank you! This was my first contribution so thanks for adding the test, I'll keep it in mind for the future! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution!
thank you for this fix! |
Closes #6793
✅ Pull Request Checklist:
📝 Test Instructions:
Run locally
Test it either in the storybook or docs (can test in timefield, datefield, datepicker)
Make sure the dayperiod is set to PM
Delete the hour
Day period should not change
🧢 Your Project: