feat: Allow ReactElement in LabeledValue value #7679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sana-malik
force-pushed
the
labeledvalue_reactnode
branch
from
352ffae to
9493cf0
Compare
reidbarber
reviewed
Jan 28, 2025
packages/@react-spectrum/labeledvalue/test/LabeledValue.test.js
Outdated
Show resolved
Hide resolved
added 3 commits
January 29, 2025 20:26
sana-malik
force-pushed
the
labeledvalue_reactnode
branch
from
7a00842 to
07ceb2c
Compare
sana-malik
force-pushed
the
labeledvalue_reactnode
branch
from
e7b1b5a to
99cb77e
Compare
| type LabeledValueStory = ComponentStoryObj<typeof LabeledValue>; | ||
|
|
||
| export default { | ||
| const meta: Meta<typeof LabeledValue> = { | ||
| title: 'LabeledValue', |
There was a problem hiding this comment.
adding this back in fixed the storybook naming structure
snowystinger
previously approved these changes
Jan 30, 2025
reidbarber
reviewed
Jan 31, 2025
| value={<input />} /> | ||
| ); | ||
| } catch (e) { | ||
| expect(e.message).toEqual('LabeledValue cannot contain an editable value.'); |
There was a problem hiding this comment.
I think it's possible that this isn't throwing, and the test is still passing. We'll want to do the assertion outside of the catch to double check this. I'll try to double check this test when I have a chance. The change looks great, but there may be something we're missing in terms of the test setup. Sorry for the delays!
There was a problem hiding this comment.
Updated the assertion outside of the catch!
reidbarber
approved these changes
Feb 3, 2025
sana-malik
changed the title
yihuiliao
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Pull Request Checklist:
📝 Test Instructions:
Storybook included as "Custom component" under "LabeledValue"
🧢 Your Project:
Adobe - Developer Home