Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use useHref'ed href for router based navigation #7695

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

use useHref'ed href for router based navigation #7695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c34f5af
add RR sample
jprosevear Feb 4, 2025
da221eb
use useHref'ed href for router based navigation
jprosevear Jan 31, 2025
50c495a
Revert "use useHref'ed href for router based navigation"
jprosevear Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react-aria-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@
"access": "public"
},
"devDependencies": {
"@tailwindcss/postcss": "^4.0.0"
"@tailwindcss/postcss": "^4.0.0",
"react-router": "^7.1.5"
}
}
78 changes: 76 additions & 2 deletions packages/react-aria-components/stories/Link.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,14 @@
* governing permissions and limitations under the License.
*/

import {Link} from 'react-aria-components';
import {
BrowserRouter,
Route,
Routes,
useHref,
useNavigate
} from 'react-router';
import {Link, RouterProvider} from 'react-aria-components';
import React from 'react';

export default {
Expand All @@ -19,8 +26,75 @@ export default {

export const LinkExample = () => {
return (
<Link data-testid="link-example" href="https://www.imdb.com/title/tt6348138/" hrefLang="en" target="_blank">
<Link
data-testid="link-example"
href="https://www.imdb.com/title/tt6348138/"
hrefLang="en"
target="_blank">
The missing link
</Link>
);
};

const LinkReactRouterExternalInner = () => {
const navigate = useNavigate();

return (
<RouterProvider navigate={navigate} useHref={useHref}>
<Routes>
<Route
path="/iframe.html"
index
element={
<Link
data-testid="link-example"
href="https://www.imdb.com/title/tt6348138/"
hrefLang="en"
target="_blank">
The missing link
</Link>
} />
</Routes>
</RouterProvider>
);
};

export const LinkReactRouterExternal = () => {
return (
<BrowserRouter>
<LinkReactRouterExternalInner />
</BrowserRouter>
);
};

const LinkReactRouterNested = () => {
return (
<>
<Link href="next_nested">The next nested Link</Link>
<Routes>
<Route path="next_nested" element={'The end of the links'} />
</Routes>
</>
);
};

const LinkReactRouterInternalInner = () => {
const navigate = useNavigate();

return (
<RouterProvider navigate={navigate} useHref={useHref}>
<Link href="nested">The nested link</Link>
<Routes>
<Route path="nested/*" element={<LinkReactRouterNested />} />
</Routes>
</RouterProvider>
);
};

export const LinkReactRouterInternal = () => {
return (
<BrowserRouter>
<LinkReactRouterInternalInner />
</BrowserRouter>
);
};