Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Shadow DOM support for useOverlay and improve event handling #7751

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ritz078
Copy link
Contributor

@ritz078 ritz078 commented Feb 9, 2025

Followup of #6046

This PR fixes an issue in useOverlay where shouldCloseOnInteractOutside always received the shadow root parent element as the argument whenever an element inside the shadow root was clicked.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Nutrient (formerly PSPDFKit)

@ritz078 ritz078 marked this pull request as ready for review February 9, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant