chore: update out of date tests and import overlay statically

adobe · Jan 31, 2025 · 1566c4c · 1566c4c
1 parent 005f71f
commit 1566c4c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 40 deletions.
diff --git a/packages/overlay/src/OverlayTrigger.ts b/packages/overlay/src/OverlayTrigger.ts
@@ -23,6 +23,7 @@ import {
     state,
 } from '@spectrum-web-components/base/src/decorators.js';
 import type { Placement } from '@floating-ui/dom';
+import '@spectrum-web-components/overlay/sp-overlay.js';
 
 import type { BeforetoggleOpenEvent } from './events.js';
 import type { Overlay } from './Overlay.js';
@@ -44,12 +45,6 @@ export type OverlayContentTypes = 'click' | 'hover' | 'longpress';
  * @fires sp-closed - Announces that the overlay has been closed
  */
 export class OverlayTrigger extends SpectrumElement {
-    constructor() {
-        super();
-        // Preload the overlay component
-        void import('@spectrum-web-components/overlay/sp-overlay.js');
-    }
-
     public static override get styles(): CSSResultArray {
         return [overlayTriggerStyles];
     }

diff --git a/packages/overlay/stories/overlay.stories.ts b/packages/overlay/stories/overlay.stories.ts
@@ -143,7 +143,7 @@ interface Properties {
     placement: Placement;
     offset: number;
     open?: OverlayContentTypes;
-    type?: Extract<TriggerInteractions, 'inline' | 'modal' | 'replace'>;
+    type?: 'modal';
 }
 
 const template = ({
@@ -508,35 +508,6 @@ export const complexModal = (): TemplateResult => {
                 display: grid;
                 place-content: center;
             }
-            active-overlay > * {
-                --spectrum-global-animation-duration-100: 0ms;
-                --spectrum-global-animation-duration-200: 0ms;
-                --spectrum-global-animation-duration-300: 0ms;
-                --spectrum-global-animation-duration-400: 0ms;
-                --spectrum-global-animation-duration-500: 0ms;
-                --spectrum-global-animation-duration-600: 0ms;
-                --spectrum-global-animation-duration-700: 0ms;
-                --spectrum-global-animation-duration-800: 0ms;
-                --spectrum-global-animation-duration-900: 0ms;
-                --spectrum-global-animation-duration-1000: 0ms;
-                --spectrum-global-animation-duration-2000: 0ms;
-                --spectrum-global-animation-duration-4000: 0ms;
-                --spectrum-animation-duration-0: 0ms;
-                --spectrum-animation-duration-100: 0ms;
-                --spectrum-animation-duration-200: 0ms;
-                --spectrum-animation-duration-300: 0ms;
-                --spectrum-animation-duration-400: 0ms;
-                --spectrum-animation-duration-500: 0ms;
-                --spectrum-animation-duration-600: 0ms;
-                --spectrum-animation-duration-700: 0ms;
-                --spectrum-animation-duration-800: 0ms;
-                --spectrum-animation-duration-900: 0ms;
-                --spectrum-animation-duration-1000: 0ms;
-                --spectrum-animation-duration-2000: 0ms;
-                --spectrum-animation-duration-4000: 0ms;
-                --spectrum-coachmark-animation-indicator-ring-duration: 0ms;
-                --swc-test-duration: 1ms;
-            }
         </style>
         <overlay-trigger type="modal" open="click">
             <sp-dialog-wrapper
@@ -929,7 +900,7 @@ export const edges = (): TemplateResult => {
 export const inline = (): TemplateResult => {
     const closeEvent = new Event('close', { bubbles: true, composed: true });
     return html`
-        <overlay-trigger type="inline">
+        <overlay-trigger>
             <sp-button slot="trigger">Open</sp-button>
             <sp-popover slot="click-content">
                 <sp-button
@@ -1095,7 +1066,7 @@ export const modalManaged = (): TemplateResult => {
 
 export const modalWithinNonModal = (): TemplateResult => {
     return html`
-        <overlay-trigger type="inline">
+        <overlay-trigger>
             <sp-button variant="primary" slot="trigger">
                 Open inline overlay
             </sp-button>
@@ -1153,7 +1124,7 @@ export const openHoverContent = (args: Properties): TemplateResult =>
 export const replace = (): TemplateResult => {
     const closeEvent = new Event('close', { bubbles: true, composed: true });
     return html`
-        <overlay-trigger type="replace">
+        <overlay-trigger>
             <sp-button slot="trigger">Open</sp-button>
             <sp-popover slot="click-content">
                 <sp-button
@@ -1312,7 +1283,7 @@ export const updating = (): TemplateResult => {
         button.style.position = 'fixed';
     };
     return html`
-        <overlay-trigger type="click">
+        <overlay-trigger>
             <sp-button variant="primary" slot="trigger">
                 Open inline overlay
             </sp-button>