chore(reactive-controllers): updates lit dependency

[jnjosh]

Description

When we updated to support Lit 2 or Lit 3 we left Reactive Controllers behind, only supporting 3. This has created downstream issues in consumers that don't support Lit 3.

How has this been tested?

• Need some help in how to best test this.

Checklist

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• If my change required a change to the documentation, I have updated the documentation in this pull request.
• I have read the CONTRIBUTING document.
• [-] I have added tests to cover my changes.
• [-] All new and existing tests passed.
• I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

[github-actions]

Branch preview

• Documentation Site
• Storybook

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

• Spectrum | Light | Medium | LTR
• Spectrum | Dark | Large | RTL
• Express | Light | Medium | LTR
• Express | Dark | Large | RTL
• Spectrum-two | Light | Medium | LTR
• Spectrum-two | Dark | Large | RTL
• High Contrast Mode | Medium | LTR

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

[github-actions]

Lighthouse scores

Category	Latest (report)	Main (report)	Branch (report)
Performance	0.99	0.98	0.99
Accessibility	1	1	1
Best Practices	1	1	1
SEO	1	0.92	0.92
PWA	1	1	1

What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category	Latest	Main	Branch
Total	249.906 kB	236.19 kB 🏆	236.387 kB
Scripts	60.614 kB	54.341 kB 🏆	54.456 kB
Stylesheet	53.271 kB	47.357 kB 🏆	47.422 kB
Document	6.223 kB	5.543 kB	5.484 kB 🏆
Font	126.838 kB	126.596 kB 🏆	126.641 kB

Request Count

Category	Latest	Main	Branch
Total	52	52	52
Scripts	41	41	41
Stylesheet	5	5	5
Document	1	1	1
Font	2	2	2

[coveralls]

Pull Request Test Coverage Report for Build 13052680003

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 98.19%

---

Totals
Change from base Build 13051780704:	0.0%
Covered Lines:	33063
Relevant Lines:	33492

---

💛 - Coveralls

[github-actions]

Tachometer results

Currently, no packages are changed by this PR...

[rubencarvalho]

I took a note to add downstream dummy consumers with different constraints to dry-run our upcoming releases. This would then be caught.
Thank you for fixing!

[TarunAdobe]

I love such PRs!!

[Rajdeepc]

Awesome! But sadly this will not work. reactive-controllers lit dependency needs to be pointed to ^3.1.3 since @spectrum-web-components/reactive-controllers 0.42.2 depends on lit ^3.1.3 which means ^2.5.0 || ^3.1.3 will not be not true in this case.

[graynorton]

reactive-controllers lit dependency needs to be pointed to ^3.1.3

@Rajdeepc, can you provide any detail on why the @spectrum-web-components/reactive-controllers package won't work with Lit 2.5.0?

[Rajdeepc]

reactive-controllers lit dependency needs to be pointed to ^3.1.3

@Rajdeepc, can you provide any detail on why the @spectrum-web-components/reactive-controllers package won't work with Lit 2.5.0?

My initial findings is that with lit: 2.5.0, storybook 7.x is not supported under @storybook/types. Component preview breaks under S7.

[graynorton]

My initial findings is that with lit: 2.5.0, storybook 7.x is not supported under @storybook/types. Component preview breaks under S7.

@Rajdeepc Let's try to sync up next week, maybe in the internal discussions meeting on Tuesday. I tried a bunch of things and couldn't identify any failures as a result of making this change, so would be good to compare notes. Thanks!

[changeset-bot]

⚠️ No Changeset found

Latest commit: 65535af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR