Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #3570

Merged
merged 10 commits into from
Jan 29, 2025
Merged

[Release] Stage to Main #3570

merged 10 commits into from
Jan 29, 2025

Conversation

Deva309 and others added 9 commits January 28, 2025 20:55
* Checks links for http vs https and informs users in SEO tab

* Additive solution to keep localizeLink logic intact. Modified messaging on status

* Changed object to use post transformation liveHref instead of url to copy what is done for the spidy check

* Modified to ensure correct assignment

* Adding test for coverage
…ee. (#3455)

* but made usable by increasing z-index

* fix for accessibility bugs
…DSET … (#3518)

* MWPW-162026 [Milo][Sev2][Catalog] Group of checkboxes is missing FIELDSET element - filter checkboxes

* Trigger Build

* Trigger Build

* MWPW-162026 [Milo][Sev2][Catalog] Group of checkboxes is missing FIELDSET element - filter checkboxes

* Rebuild mas

* Rebuild mas

* MWPW-162026 [Milo][Sev2][Catalog] Group of checkboxes is missing FIELDSET element - filter checkboxes

---------

Co-authored-by: Bozo Jovicic <[email protected]>
…ttributes - Gnav (#3521)

* Fixing Breadcrumb issue

* Updating unit test

---------

Co-authored-by: Snehal Sonawane <[email protected]>
* MWPW-166355 [MEP] Number and symbols are very small in MEP button on RTL pages (#3541)

update font family

* MWPW-166002 | [MEP] Use Target served version of manifest in prod when Target experience is chosen (#3527)

* Added server vs target manifest handling

* refactored a bit

* refactored test

---------

Co-authored-by: Denys Fedotov <[email protected]>

* MWPW-159369 [cc][LANA] Error reported: target response time: 0.5 (#3475)

* add sample rate

* change error type

* MWPW-156867 [MILO][MEP][ANALYTICS] Support Column nicknames (#3510)

* stash

* ready to publish

* interact call coming back but timing out

* working on a fast connection

* clean up ifs

* working with promise

* use camel case on let variable

* unit tests

* create mepxlg branch

* update library

* require full hostname match

* update reference for unit test

* update unit tests

* switch to use config instead of domain list and stub response in unit test

* update fetch to 2

* updating another fetch to 2

* restore normalizePath to use preview domains on preview links

* preload segment list json

* use getFederatedUrl instead

* import at top so we don't have to make normalizePath async

* add federated link function to registerInBlockActions

* add to unit test

* initial commit

* stash commit

* remove dupe valMap const

* update test files

* linting error fix

---------

Co-authored-by: vgoodric <[email protected]>

* MWPW-166639 [MEP] Removing OST links doesn't work when MEP button is on (#3556)

exclude ost links from highlight

---------

Co-authored-by: Denys Fedotov <[email protected]>
Co-authored-by: Denys Fedotov <[email protected]>
Co-authored-by: Jan Ivan Viloria <[email protected]>
* First working version

* Adds preview warning message

* Revert "Adds preview warning message"

This reverts commit 633db7f.

* Updates the Use Preview Content help message

* MWPW-165869: fixes linting errors

* MWPW-165869: fixes linting errors

* MWPW-165869: updates use preview content label
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Jan 28, 2025

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot

Copy link
Contributor

aem-code-sync bot commented Jan 28, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 28, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (0a9e222) to head (56128d6).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3570      +/-   ##
==========================================
- Coverage   96.49%   96.48%   -0.01%     
==========================================
  Files         260      260              
  Lines       60763    60808      +45     
==========================================
+ Hits        58632    58671      +39     
- Misses       2131     2137       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Co-authored-by: Ryan Clayton <[email protected]>
@milo-pr-merge milo-pr-merge bot merged commit 7097c97 into main Jan 29, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.