Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #3701

Merged
merged 9 commits into from
Feb 19, 2025
Merged

[Release] Stage to Main #3701

merged 9 commits into from
Feb 19, 2025

Conversation

skholkhojaev and others added 9 commits February 18, 2025 18:02
* fixed the flaky test for logWebVitalsUtils.test.js (#1)

* fixed the flaky test

* move performance mock to beforeEach/afterEach for isolation, simplify lcpElType check

* removed unused code

* fixed the same issue in logWebVitals.test.js and reverted unnecessary changes

* Update fstab.yaml

* Update fstab.yaml

* Update fstab.yaml

* Update fstab.yaml

* Update fstab.yaml

* enhanced tool tips Unit tests

* added assertions and isolated DOM state

* changed unnecessary async to sync

* added loadIcons for duplicate test

* tooltip should be visible on hover

* added a test case for visibility of tooltip

* testcase for tooltip visibility

* Changes visibility test case & gave appropriate name to tests

* Update test/features/icons/icons.test.js

Co-authored-by: Robert Bogos <[email protected]>

---------

Co-authored-by: Robert Bogos <[email protected]>
…t mode when the text is long (#3672)

fix situations where a line break was needed in a mega menu in the mobile gnav
…ost branch quick link (#3687)

* ecid null case

* ecid access

* branch banner

* reverting change

---------

Co-authored-by: Drashti Modasara <[email protected]>
* Fixing lana log tags and error types

* Adding standalone gnavs as meta source for lana logging

* Adding lana log for standalone onError

* Lint and test case fix

* Fixing test case

* Fixing test case

* Fixing test case

* Lint fix

* Code fix

* Adding test case for breadcrumbs

* Code fix

* Removing unnecessary log

* Removing unnecessary log
* Added fix for contrast ratio for blue link on grey background

* Fix other issues

* link color updates for milo as well

* reverted color for button

* reverted color for button

---------

Co-authored-by: Dev Ashish Sardana <[email protected]>
* [MWPW-167312] tooltip dismiss escape

* [MWPW-167312] unit test added
* MWPW-164755:Add <br> when copying multiple blocks

* MWPW-164755: Update mocks

* MWPW-164755: Add <br> after every element in the container

* MWPW-164755: Remove string from blob

Co-authored-by: Okan Sahin <[email protected]>

---------

Co-authored-by: Okan Sahin <[email protected]>
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Feb 18, 2025

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot

Copy link
Contributor

aem-code-sync bot commented Feb 18, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Feb 18, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@milo-pr-merge milo-pr-merge bot merged commit f6e9d43 into main Feb 19, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.