New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #3718

Open

milo-pr-merge wants to merge 7 commits into main from stage

+737 −430

Contributor

milo-pr-merge bot commented Feb 20, 2025 •

edited by mokimo

Loading

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

st-angelo-adobe and others added 3 commits

February 20, 2025 17:53


          MWPW-158500: Universal promo terms link (#3647)

05409ce

* init upt-link

* mas-element fix

* missing build

* callback check

* correct href

* upt link error handling

* refined link

* ccd revert, encoded URI

* build

* hook name conflict fix

* upt link in hydration

* is attribute

* upt-link fix; nala tests

* nala test updates

* undefined promo code fix

* promo terms url based on env


          MWPW-164728 [MMM] Improve design of pagination (#3669)

fd41709

* after history reset

* opcity change remove dropdown disabled

* comment cleanup

* createPageList fix added search params

* search param update

* remove perpage pagenum from shareurl hrefs

* comment changes

---------

Co-authored-by: Denys Fedotov <[email protected]>


          [MWPW-168041] pill tab border removal (#3699)

74c557f

* [MWPW-168041] pill tab border removal

* [MWPW-168041] optimization

Contributor Author

milo-pr-merge bot commented Feb 20, 2025

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot

Contributor

aem-code-sync bot commented Feb 20, 2025 •

edited

Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

b365db2 ✅ (latest)
60ccc33 ✅
67fbb44 ✅
896f5f5 ✅
74c557f ✅
fd41709 ✅
05409ce ✅

Contributor

aem-code-sync bot commented Feb 20, 2025 •

edited

Loading

	Page	Scores	Audits	Google
📱	/?martech=off
🖥️	/?martech=off

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/74c557f3ed33f903e92f811cd6768a6a2804523d/libs/deps/mas/merch-stock.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/74c557f3ed33f903e92f811cd6768a6a2804523d/libs/deps/mas/merch-subscription-panel.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/74c557f3ed33f903e92f811cd6768a6a2804523d/libs/deps/mas/merch-twp-d2p.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/74c557f3ed33f903e92f811cd6768a6a2804523d/libs/deps/mas/merch-whats-included.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/74c557f3ed33f903e92f811cd6768a6a2804523d/libs/features/mas/dist/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/74c557f3ed33f903e92f811cd6768a6a2804523d/libs/features/mas/src/commerce.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/74c557f3ed33f903e92f811cd6768a6a2804523d/libs/features/mas/src/hydrate.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/74c557f3ed33f903e92f811cd6768a6a2804523d/libs/features/mas/src/upt-link.js

github-actions bot reviewed

View reviewed changes

libs/deps/mas/commerce.js

Contributor

github-actions bot Feb 20, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/deps/mas/mas.js

Contributor

github-actions bot Feb 20, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/deps/mas/merch-card-collection.js

Contributor

github-actions bot Feb 20, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/deps/mas/merch-card.js

Contributor

github-actions bot Feb 20, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/deps/mas/merch-icon.js

Contributor

github-actions bot Feb 20, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/deps/mas/merch-mnemonic-list.js

Contributor

github-actions bot Feb 20, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/deps/mas/merch-offer-select.js

Contributor

github-actions bot Feb 20, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/deps/mas/merch-quantity-select.js

Contributor

github-actions bot Feb 20, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/deps/mas/merch-secure-transaction.js

Contributor

github-actions bot Feb 20, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/deps/mas/merch-sidenav.js

Contributor

github-actions bot Feb 20, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

mokimo temporarily deployed to milo_pr_merge

February 20, 2025 20:15

— with

GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge

February 21, 2025 01:09

— with

GitHub Actions Inactive


          DOTCOM-128841, DOTCOM-129276, Group of navigation links missing seman…

896f5f5

…tics (#3559)

* DOTCOM-128841, DOTCOM-129276,  Group of navigation links missing semantics

* fix linting errors

* DOTCOM-128841 change p tag to div

* wrap footer links with ul li

* replace span with before element for divider, to mentain semantics

* undo last changes

* move divider in li

* remove divider form semantic testing purpose

* undo last commit

* move copyright inside list

* undo reader fix

* wrap copyright in list item

* remove whitespace

* add fix for two sections

milo-pr-merge bot requested review from salonijain3, bandana147, sharmrj, nishantka, Deva309 and sonawanesnehal3 as code owners

February 21, 2025 01:09


          MWPW-165992 Fix Chart Font Family (#3685)

67fbb44

milo-pr-merge bot requested review from meganthecoder, Brandon32 and JasonHowellSlavin as code owners

February 21, 2025 01:09

github-actions bot reviewed

View reviewed changes

libs/deps/mas/merch-stock.js

Contributor

github-actions bot Feb 21, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/deps/mas/merch-subscription-panel.js

Contributor

github-actions bot Feb 21, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/deps/mas/merch-twp-d2p.js

Contributor

github-actions bot Feb 21, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/deps/mas/merch-whats-included.js

Contributor

github-actions bot Feb 21, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/features/mas/dist/mas.js

Contributor

github-actions bot Feb 21, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/features/mas/src/commerce.js

Contributor

github-actions bot Feb 21, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/features/mas/src/hydrate.js

Contributor

github-actions bot Feb 21, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/features/mas/src/upt-link.js

Contributor

github-actions bot Feb 21, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

mokimo temporarily deployed to milo_pr_merge

February 21, 2025 04:18

— with

GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge

February 21, 2025 08:18

— with

GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge

February 21, 2025 09:15

— with

GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge

February 21, 2025 09:56

— with

GitHub Actions Inactive


          Move federal code to utils (#3591)

60ccc33

* Move federal base code to utils

* Migrate federated.js

* Fix linting errors

aem-code-sync bot temporarily deployed to stage

February 21, 2025 09:59

Inactive


          [MWPW-168268] Correct RCP dates in Slack comms (#3717)

b365db2

github-actions bot reviewed

View reviewed changes

.github/workflows/rcp-notifier.js

Contributor

github-actions bot Feb 21, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored by default. Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override.

mokimo temporarily deployed to milo_pr_merge

February 21, 2025 12:28

— with

GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge

February 21, 2025 16:18

— with

GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge

February 21, 2025 20:15

— with

GitHub Actions Inactive

Dli3 approved these changes

View reviewed changes

Dli3 added the BAcom SOT 👌 label

Dli3 temporarily deployed to milo_pr_merge

February 22, 2025 00:45

— with

GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge

February 22, 2025 01:07

— with

GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge

February 22, 2025 04:16

— with

GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge

February 22, 2025 08:16

— with

GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge

February 22, 2025 09:14

— with

GitHub Actions Inactive

mokimo deployed to milo_pr_merge

February 22, 2025 12:25

— with

GitHub Actions Active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

github-actions[bot] github-actions[bot] left review comments

Dli3 Dli3 approved these changes

salonijain3 Awaiting requested review from salonijain3 salonijain3 is a code owner

bandana147 Awaiting requested review from bandana147 bandana147 is a code owner

sharmrj Awaiting requested review from sharmrj sharmrj is a code owner

nishantka Awaiting requested review from nishantka nishantka is a code owner

Deva309 Awaiting requested review from Deva309 Deva309 is a code owner

sonawanesnehal3 Awaiting requested review from sonawanesnehal3 sonawanesnehal3 is a code owner

meganthecoder Awaiting requested review from meganthecoder meganthecoder is a code owner

Brandon32 Awaiting requested review from Brandon32 Brandon32 is a code owner

JasonHowellSlavin Awaiting requested review from JasonHowellSlavin JasonHowellSlavin is a code owner

At least 3 approving reviews are required to merge this pull request.

Labels