Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-168334 Load georoutingv2.json and georoutingv2.js in parallel #3720

Open
wants to merge 4 commits into
base: stage
Choose a base branch
from

Conversation

sharmrj
Copy link
Contributor

@sharmrj sharmrj commented Feb 21, 2025

  • Load georoutingv2.json and georoutingv2.js in parallel
  • slightly refactored the logic for the failover
  • return early when using old georouting to avoid an error where the body of the response gets read twice (response bodies can only be read once)
  • This will need to be merged before MWPW-167716 Remove await from both gnav and georouting #3680

Before:
Screenshot 2025-02-21 at 11 46 05 AM
After:
Screenshot 2025-02-21 at 11 47 26 AM
Measurement done on slow 4G.

Resolves: MWPW-168334

Test URLs:

https://main--cc--adobecom.hlx.page?milolibs=optimize-georouting

Copy link
Contributor

aem-code-sync bot commented Feb 21, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Feb 21, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@afmicka
Copy link
Contributor

afmicka commented Feb 21, 2025

@sharmrj Could you please update with the latest stage? Looks like there might not be all updated, causing Nala tests to fail. The new changes merged with the new train are not rendering on this branch
cc: @skumar09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants