MWPW-166076 Update a.com Business plans page CTAs to point to CME-1 M7 #3723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 21, 2025 13:46
…7 Business plans page
…7 Business plans page
|
…7 Business plans page
narcis-radu
requested changes
Feb 21, 2025
libs/utils/utils.js
Outdated
| @@ -737,6 +763,13 @@ export function decorateLinks(el) { | |||
| processQuickLink(a); | |||
| })(); | |||
| } | |||
|
|
|||
| if (a.href.includes(BUSINESS_PLANS_PATH)) { | |||
There was a problem hiding this comment.
Have you explored using an autoblock for such scenario? I think it would be better instead of adding all the logic in utils.
There was a problem hiding this comment.
@bozojovicic - you can see caas or faas autoblocks for reference
There was a problem hiding this comment.
I created it libs/blocks/m7business/m7business.js
BTW, autoblock is awesome idea!
added 3 commits
February 21, 2025 16:23
…7 Business plans page
…7 Business plans page
…7 Business plans page
added 2 commits
February 21, 2025 17:05
…7 Business plans page
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all
/creativecloud/business-plans.htmlwith/store/segmentationlinkswhere the
coparameter value is read from user's profile if user is logged inotherwise it is taken from page locale.
Resolves: MWPW-166076
Test URLs: