Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Machine Schema for PerfNext #72

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Conversation

piyush286
Copy link
Contributor

• Added a machine schema for machine data file
• Added a template machine data file

Closes #71
Another Related Issue: adoptium/jenkins-helper#25

Signed-off-by: piyush286 [email protected]

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piyush286 - please add a license at the top of these files, as we do with other xml files (example: https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/openjdk_regression/playlist.xml#L2-L14)

• Added a machine schema for machine data file
• Added a template machine data file

Closes adoptium#71
Another Related Issue: adoptium/jenkins-helper#25

Signed-off-by: piyush286 <[email protected]>
@piyush286
Copy link
Contributor Author

@smlambert Thanks! Added those license headers! Btw just wondering whether we need to add those headers to all our other files. I guess it's just good practice to mention the license info.

Looking at this openjdk-test-tools repo, we just have 35 files, mainly xml, with those headers while over 250 files of all types on the openjdk-tests repo.

openjdk-test-tools repo:
image

openjdk-tests repo:
image

@smlambert
Copy link
Contributor

smlambert commented Mar 21, 2019

Yes, typically all files should have the Apache V2 license in the header, if they are destined for AdoptOpenJDK repos. There may a few file types that we do not bother to do so, but generally all.

Format differs slightly depending on what type the file is (xml vs java vs other languages), can look in the other AdoptOpenJDK repos, as you have done to find examples for most file types.

In a separate PR we can update some additional files in this repo, do not worry about it as part of this PR.

@smlambert smlambert merged commit be7d952 into adoptium:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants