Move SHA check function to TKG #5819
Draft
+13
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends adoptium/TKG#651 |
sophia-guo
force-pushed
the
sha
branch
3 times, most recently
from
b264e31 to
d4580a6
Compare
sophia-guo
force-pushed
the
sha
branch
3 times, most recently
from
ede8d5a to
2145bef
Compare
llxia
reviewed
Jan 10, 2025
Comment on lines
+664
to
+667
| mkdir -p ../git-backup | ||
| mv .git ../git-backup | ||
| rm -rf * | ||
| mv ../git-backup .git |
There was a problem hiding this comment.
I do not think we should move .git file around. Can we move it into the subfolder? In this case, it should be functional.
There was a problem hiding this comment.
.git is not moved around. .git keeps in openj9/.git and all others under openj9 are removed. Same for all available vendors repo as vendor*/.git.
aqa-tests/functional may also have other vendor's test material. For example eclispe adoptium https://github.com/adoptium/temurin-build/tree/master/test/functional/ so it's not good to move .git to aqa-tests/functional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5818