Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct EA build status in daily Slack build status when recent builds are GA ones #1183

Merged
merged 22 commits into from
Feb 9, 2025

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Feb 7, 2025

The daily slack EA build status incorrectly reports EA Build status just after GA releases, and also incorrectly determines
jdk8u-aarch32 EA build tags. The reason being because the recent build tag back search doesn't search past the GA tags...

  • Corrected the EA asset search to skip GA builds
  • Corrected the jdk8u-aarch32 GA tag comparison to work out the correct jdk8u-aarch32-port GA tags
  • Corrected reported "build in-progress" status when current published build is the latest but it is missing assets...
  • When reporting AQA test status and build is in-progress(Streaming) the completed AQA tests were not being reported for the in-progress build

Slack status from yesterday used this PR: https://adoptium.slack.com/archives/C09NW3L2J/p1738841633827389

Copy link

github-actions bot commented Feb 7, 2025

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@github-actions github-actions bot added code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts aarch labels Feb 7, 2025
@andrew-m-leonard andrew-m-leonard self-assigned this Feb 7, 2025
@andrew-m-leonard andrew-m-leonard requested a review from sxa February 7, 2025 11:16
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to rubber stamp this on the basis it seems to work and looks sane. Thanks for Sorting the special case that we had for the rogue solaris "release" :-)

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@karianna karianna merged commit 0601e15 into adoptium:master Feb 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts testing
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants