Play 2.7 support (and cross build for Scala 2.13.0-M5)

[mkurz]

Please add support for Play 2.7.
https://blog.playframework.com/play-2-7-0-is-here/
https://www.playframework.com/documentation/2.7.x/Highlights27
https://www.playframework.com/documentation/2.7.x/Migration27

Please also publish builds for Scala 2.13.0-M5. (Add it to crossScalaVersions, also please update to latest 2.12 and latest 2.11)
Your probably have to set PlayKeys.playOmnidoc := false in build.sbt to make it work.

Also it could be that you have to adjust some twirl templates because now curly brackets are needed in some cases.
E.g. twirl code like

@something.map { case SomeThing(foo) =>
	some html
}

becomes this:

@something.map { case SomeThing(foo) => {
	some html
}}

[adrianhurt]

Hi @mkurz! I've just finally released the snapshots for 1.5 versions with Play 2.7 (the code is on branch develop). Please, try to test it. I've just found a lot of warnings like this one:

[warn] /path/to/play-bootstrap/play27-bootstrap4/module/app/views/b4/buttonType.scala.html:4:16:
Passing an explicit array value to a Scala varargs method is deprecated (since 2.13.0) and will result in a defensive copy;
Use the more efficient non-copying ArraySeq.unsafeWrapArray or an explicit toIndexedSeq call
[warn] }(fc, msgsProv)

I'll try to check them as soon as possible and to update the docs as well.

The snapshots versions are:

• 1.5-P27-B4-SNAPSHOT
• 1.5-P26-B4-SNAPSHOT

[mkurz]

@adrianhurt Thanks! I will check it out as soon as possible! Again thank you very much for your efforts!

[bjoernhaeuser]

I tested the 2.7 snapshot and it looks very good to me, though I only have a minor use case - two simple forms.

[mkurz]

I think we should wait with the next release until next week because then Scala 2.13 will be released and also Play will be published for Scala 2.13 - meaning also play-bootstrap can then also published for Scala 2.13 as well.

[adrianhurt]

Yes, I think it’s better to wait as well. I’d only update something to fix bugs if needed, but please, test it if you all have time.

[bjoernhaeuser]

Scala 2.13 is now released, looking forward to the release of play-boostrap. Thank you!

[mkurz]

@bjoernhaeuser yes but we need Play to support Scala 2.13 first

[ahjohannessen]

2.13.0 support in Play 2.7.3

[adrianhurt]

Great! I’ll try to update it this weekend!

[mkurz]

@adrianhurt I will submit a pull request later today with an important fix. Please wait for it, thanks!

[mkurz]

Please don't release yet, as I said will provide a pull request with a bugfix very soon!

[adrianhurt]

Don't worry, I'll wait for it.

[mkurz]

@adrianhurt Done, see #121 (also maybe merge #120 before).
Let me know if you need help. Thanks!

[adrianhurt]

Hi! I've just released versions 1.5-P2X-BX-RC-SNAPSHOT with Play 2.7.3 (note the -RC). If you don't see any problem I'll release the final one during the next week.

I've noted the syntax 'foo for a symbol has been deprecated, so I suppose in the version 1.6 I'll substitute (maybe) every symbol by a simple string.

[mkurz]

@adrianhurt Just did a small test, for me it looks good, thanks!

[bjoernhaeuser]

Same here :) small test was successful! Thanks!

[adrianhurt]

Hey guys! It's finally released

[mkurz]

Thanks!

[mkurz]

I've noted the syntax 'foo for a symbol has been deprecated, so I suppose in the version 1.6 I'll substitute (maybe) every symbol by a simple string.

That is what Play itself will do as well: See playframework/playframework#9447 and playframework/playframework#9488. Therefore 'key -> "value" will become "key" -> "value"...

[fooblahblah]

Any updates on the Symbol deprecation thing? I'm trying to get our app compiling under 2.13.1 and the last issue is the Play template using literal Symbols. I migrated to the Symbol("foo") syntax, but get some implicit errors, but maybe it's unrelated? BTW, I'm using 1.5.1-P27-B3

could not find implicit value for parameter fc: views.html.b3.package.B3FieldConstructor
[error]               @b3.select(catForm("categoryType"), categoryTypeSelectOptions, Symbol("_label") -> "Category Type")

[mkurz]

@fooblahblah No updates yet. I think the implicit error you face is not related to symbols.

[fooblahblah]

Thanks @adrianhurt. I'm starting to think the same. I need to figure out why these usages started breaking when I changed versions of the library.

[mkurz]

See #124 for the symbol issue.