Remove deprecated Symbol literal #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
find core-play27/ play27-bootstrap3/ play27-bootstrap4/ -name *.scala.html | xargs sed -i "s/'\([^> ]\+\) ->/Symbol(\"\1\") ->/g"
find core-play27/ play27-bootstrap3/ play27-bootstrap4/ -name *.scala.html | xargs sed -i "s/get('\([^) ]\+\))/get(Symbol(\"\1\"))/g"
find core-play27/ play27-bootstrap3/ play27-bootstrap4/ -name *.scala.html | xargs sed -i "s/'\([^) ]\+\))/Symbol(\"\1\"))/g"
find core-play27/ play27-bootstrap3/ play27-bootstrap4/ -name *.scala.html | xargs sed -i "s/'\([^, ]\+\),/Symbol(\"\1\"),/g"
|
@adrianhurt I know you mentioned you want to replace symbol with a simple string. However that would break all templates that take symbol parameters... I am working towards being able to deprecate twirl template arguments: playframework/twirl#273 |
cd core-play27/ sbt clean "scalafix dependency:[email protected]:scala-rewrites:0.1.0-SNAPSHOT" sbt clean "test:scalafix dependency:[email protected]:scala-rewrites:0.1.0-SNAPSHOT" cd ../play27-bootstrap3/module/ sbt clean "scalafix dependency:[email protected]:scala-rewrites:0.1.0-SNAPSHOT" sbt clean "test:scalafix dependency:[email protected]:scala-rewrites:0.1.0-SNAPSHOT" cd ../sample/ sbt clean "scalafix dependency:[email protected]:scala-rewrites:0.1.0-SNAPSHOT" sbt clean "test:scalafix dependency:[email protected]:scala-rewrites:0.1.0-SNAPSHOT" cd ../../play27-bootstrap4/module/ sbt clean "scalafix dependency:[email protected]:scala-rewrites:0.1.0-SNAPSHOT" sbt clean "test:scalafix dependency:[email protected]:scala-rewrites:0.1.0-SNAPSHOT" cd ../sample/ sbt clean "scalafix dependency:[email protected]:scala-rewrites:0.1.0-SNAPSHOT" sbt clean "test:scalafix dependency:[email protected]:scala-rewrites:0.1.0-SNAPSHOT" cd ../../
mkurz
force-pushed
the
fix-symbol-literals
branch
from
f83f16f to
b99a160
Compare
Closed
|
Ping @adrianhurt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only effects the Play 2.7 folders:
core-play27,play27-bootstrap3,play27-bootstrap4(because of Scala 2.13 support)I did not do this manually. The first four commits were done via regex, effecting the
*.scala.htmlfiles only:The fifth commit was done via
sbt-scalafixandScalafix Rewrites- to fix all the*.scalafiles. I temporarly added it toproject/plugins.sbt/build.sbt, see this commit (in my own branch). I had to clone https://github.com/scala/scala-rewrites before andpublishLocalit. Then I could run it via:See