Minor refactoring

adrianscheit · Feb 6, 2025 · cc25244 · cc25244
1 parent f8edce4
commit cc25244
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 14 deletions.
diff --git a/pages/index.html b/pages/index.html
@@ -115,7 +115,7 @@ <h2 class="error"></h2>
     </form>
     <section>
         <h3>Send frame</h3>
-        <p>If there is already a master on the bus, this operation can cause a frame colision on the bus!</p>
+        <p>If there is already a master on the bus, this operation can cause a frame colision on the bus.</p>
         <form name="send">
             <fieldset>
                 <legend>Send any frame:</legend>
@@ -125,8 +125,7 @@ <h3>Send frame</h3>
                 </label>
                 <label>
                     Function code:
-                    <input id="functionCode" type="number" name="functionCode" list="functionCodeList" min="0" max="255"
-                        step="1" required></select>
+                    <input id="functionCode" type="number" name="functionCode" list="functionCodeList" min="0" max="255" step="1" required></select>
                     <datalist id="functionCodeList"></datalist>
                 </label>
                 <label>

diff --git a/src/frame.ts b/src/frame.ts
@@ -33,7 +33,7 @@ export class Frame {
 
     getRow(): TableDataColumn[] {
         return [
-            new TableDataColumn(Frame.getDateTime(), this.type),
+            new TableDataColumn(`${Frame.getDateTime()} (${this.type})`, this.type),
             new TableDataColumn(`${this.slaveAddress} = 0x${Converters.byteToHex(this.slaveAddress!)}`, this.type),
             new TableDataColumn(FunctionCodes.getDescription(this.functionCode), this.type),
             new TableDataColumn(this.getDataLength().toString(), this.type),

diff --git a/src/function-codes.ts b/src/function-codes.ts
@@ -55,7 +55,7 @@ export class FunctionCodes {
         if (description) {
             return this._getDescription(code, description);
         }
-        return this._getDescription(code, '<UNKNOWN>');
+        return this._getDescription(code, '(UNKNOWN)');
     }
 
     private static _getDescription(code: number, description: string): string {

diff --git a/src/main.ts b/src/main.ts
@@ -12,12 +12,8 @@ if (!serial) {
     Dom.serialForm.setFieldsetDisabled(true);
 }
 
-Dom.clearSnifferButton.addEventListener('click', () => {
-    clearSniffingTable();
-});
-Dom.downloadSnifferButton.addEventListener('click', () => {
-    downloadAllSniffedEntries();
-});
+Dom.clearSnifferButton.addEventListener('click', () => clearSniffingTable());
+Dom.downloadSnifferButton.addEventListener('click', () => downloadAllSniffedEntries());
 
 Dom.serialForm.submit = (formData) => {
     formData.baudRate = +formData.baudRate;
@@ -81,9 +77,7 @@ Dom.sendForm.submit = (formData) => {
     }
     const frameBytes: number[] = [formData.slaveAddress, formData.functionCode, ...bytes];
     insertFrameRow(new Frame([...frameBytes], 'send'));
-    if (send) {
-        send(frameBytes);
-    }
+    send?.(frameBytes);
 };
 
 // intTest();