Employees - Homepage #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added employees list &filter by different criteria.
ghost
added
the
lau32
reviewed
Aug 31, 2017
| @@ -19,13 +19,14 @@ export class FilterDropdown extends React.Component { | |||
| render() { | |||
| let criteria = this.state.criteria; | |||
| let elements = this.state.elements; | |||
| debugger; | |||
There was a problem hiding this comment.
No comments needed.
Fix it please.
lau32
suggested changes
Sep 1, 2017
| @@ -0,0 +1,117 @@ | |||
| // import React, { PropTypes } from 'react'; | |||
There was a problem hiding this comment.
Don't include files that are not used.
| return ( | ||
| <select onChange={this.filterByCriteria}> | ||
| <option value="empty"> | ||
| Filter by {criteria} | ||
| </option> | ||
| {elements.map(filter => | ||
| <option value={filter}> | ||
| <option key={filter} value={filter}> |
There was a problem hiding this comment.
Even thought it works, there are much better choises for an element key.
An index (although it's not recomanded) would be a better solution.
| @@ -79,6 +79,12 @@ export class EmployeesList extends React.Component { | |||
| )} | |||
| </tbody> | |||
| </table> | |||
| {/* | |||
There was a problem hiding this comment.
Don't include commented code.
|
|
||
| export class EmployeesList extends React.Component { | ||
| constructor(props, context) { | ||
| super(props, context); |
There was a problem hiding this comment.
The context parameter isn't needed here.
| } | ||
|
|
||
| render() { | ||
| let employeesFiltered = this.state.employeesFiltered; |
There was a problem hiding this comment.
Using let that often in any function is a big code smell.
The render function is called at every state/props change. So everything used inside it can be immutable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Implement EmployeesHomepage
Benefits: you can filter employees by multiple criterias (position, manager, project)
Possible Drawbacks: n/a
Applicable Issues: multiple filters don't work at the same time