Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

feat(templates): adding external templates #2215

Closed
wants to merge 13 commits into from
Closed

feat(templates): adding external templates #2215

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
949d11f
feat(templates): ability to add external templates
RinkiyaKeDad Nov 17, 2020
4ca9416
feat(templates): split templates into categories
RinkiyaKeDad Nov 21, 2020
a76f94f
feat(template): minor fixes
RinkiyaKeDad Nov 21, 2020
f12aad0
feat(templates): changed display style
RinkiyaKeDad Nov 24, 2020
a2b576f
feat(templates): linting fix
RinkiyaKeDad Nov 24, 2020
8b103c1
feat(templates): linting fix 2
RinkiyaKeDad Nov 24, 2020
f6a8399
feat(templates): cleared json file
RinkiyaKeDad Nov 24, 2020
c2d84c6
feat(templates): removed external flag
RinkiyaKeDad Nov 24, 2020
b8d9c69
feat(templates): fixed build error due to empty json file
RinkiyaKeDad Nov 24, 2020
5dabe76
feat(templates): fixed build errors
RinkiyaKeDad Nov 25, 2020
1910103
feat(templates): fixed another import
RinkiyaKeDad Nov 25, 2020
d1d9974
docs(templates): added draft doc
RinkiyaKeDad Dec 2, 2020
1fbba2c
feat(templates): switched from json file to ts
RinkiyaKeDad Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion community-templates.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"branch": "templates-1.0.0",
"path": "/templates/ts-apollo-postgres-backend"
}
]
],
"external": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea is that this file will be for external ones so do we need flag

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need the flag somewhere. If not here then I could have it for the internal templates, something like internal: true?

}
]
2 changes: 1 addition & 1 deletion packages/create-graphback/src/init/components.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ async function chooseTemplate(filter: string = ''): Promise<Template> {
{
type:'list',
name:'typeOfTemplates',
message:'Choose between community or officail Graphback templates',
message:'Choose between community or official Graphback templates',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to print them separately? Too much ask?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separately as in no choosing and just all of them listed with some gap (or a line saying that 'following are the community templates') in between?

choices:['community','official']
}
]);
Expand Down