This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
fix: add CORS setup #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will look into this |
|
I'm not sure if makes sense to bring framework into this. @chirino WDYT? |
|
I think this is fine and I think overtime more options of the framework may need to be exposed so that admins can control who can connect to the endpoint. |
|
lgtm |
|
@chirino thank you so much. Yes. This is just start. I wanted you to approve choice of the framework. If we pick some more top level framework we can now take number of improvements like cors wildcards etc. |
|
@namit-chandwani Thank you for contribution. Verified. All good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made:
I have added a basic CORS setup using the rs/cors package.
Further Comments:
However, to test these changes when containerized, I created a new docker image with the updated code (by executing the
build.shscript present in thedocker/directory).After running this latest image as a container, I noticed that the initial docker image issue which was pointed out in #39, still exists.
Do I need to make any further changes to the CORS config in order to fix it?