Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse nil keys properly in query operations #457

Merged
merged 6 commits into from
Nov 29, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
return nil instead of NewNullValue()
reugn committed Nov 28, 2024
commit f9b52d793d1ccb18b3189d414f4fa7e5b1ce2e58
2 changes: 1 addition & 1 deletion value.go
Original file line number Diff line number Diff line change
@@ -1276,7 +1276,7 @@ func bytesToKeyValue(pType int, buf []byte, offset int, length int) (Value, Erro
return ListValue(v), nil

case ParticleType.NULL:
return NewNullValue(), nil
return nil, nil

default:
return nil, newError(types.PARSE_ERROR, fmt.Sprintf("ParticleType %d not recognized. Please file a github issue.", pType))