-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KO-372: Drop support for old server versions and K8s APIs #337
base: master
Are you sure you want to change the base?
Conversation
abhishekdwivedi3060
commented
Jan 13, 2025
•
edited
Loading
edited
- Dropped support for v1beta1 AerospikeCluster API
- Dropped support for server version < 6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this as well
v, err := lib.CompareVersions(version, "6.0.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an explicit validation in the webhook to ensure the server version is less than 6?
It seems schema validation would catch this, but the error message might not clearly indicate that the failure is due to the minimum version requirement.
There is a explicit min server version check in webhook validation, something like this:
|