Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KO-372: Drop support for old server versions and K8s APIs #337

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

abhishekdwivedi3060
Copy link
Collaborator

@abhishekdwivedi3060 abhishekdwivedi3060 commented Jan 13, 2025

  • Dropped support for v1beta1 AerospikeCluster API
  • Dropped support for server version < 6.0

@abhishekdwivedi3060 abhishekdwivedi3060 changed the title WIP: KO-372: Drop support for old server versions and K8s APIs KO-372: Drop support for old server versions and K8s APIs Jan 22, 2025
Copy link
Contributor

@tanmayja tanmayja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this as well

v, err := lib.CompareVersions(version, "6.0.0")

Copy link
Contributor

@tanmayja tanmayja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an explicit validation in the webhook to ensure the server version is less than 6?

It seems schema validation would catch this, but the error message might not clearly indicate that the failure is due to the minimum version requirement.

@abhishekdwivedi3060
Copy link
Collaborator Author

Is there an explicit validation in the webhook to ensure the server version is less than 6?

It seems schema validation would catch this, but the error message might not clearly indicate that the failure is due to the minimum version requirement.

There is a explicit min server version check in webhook validation, something like this:

admission webhook "vaerospikecluster.kb.io" denied the request: image version 5.7.0.1 not supported. Base version 6.0.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants