Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various types #1245

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Haselnussbomber
Copy link
Contributor

@Haselnussbomber Haselnussbomber commented Dec 7, 2024

There are probably more wrong.

@github-actions github-actions bot added the breaking change PR contains breaking changes and wont be merged before a new patch label Dec 7, 2024
@Haselnussbomber Haselnussbomber force-pushed the fix-return-types branch 2 times, most recently from c7bf9e1 to 3d93b28 Compare December 16, 2024 18:37
@Haselnussbomber Haselnussbomber changed the title Fix various return types Fix various (return) types Jan 15, 2025
@Haselnussbomber Haselnussbomber changed the title Fix various (return) types Fix various types Jan 15, 2025
Copy link
Contributor

Breaking Changes

Member exists in left but not in right

FFXIVClientStructs.FFXIV.Client.Game: 1

GameMain: 1

  • uint CurrentTerritoryIntendedUseId

FFXIVClientStructs.FFXIV.Component.SteamApi.SteamApi.Delegates: 1

Ctor: 2

  • void Invoke(FFXIVClientStructs.FFXIV.Component.SteamApi.SteamApi*)
  • void EndInvoke(System.IAsyncResult)

FFXIVClientStructs.FFXIV.Component.SteamApi: 1

SteamApi: 1

  • void Ctor()

FFXIVClientStructs.FFXIV.Client.Graphics.Render: 1

SubView: 1

  • void* Camera

FFXIVClientStructs.FFXIV.Client.Graphics.Scene.Camera.Delegates: 1

ScreenPointToRay: 2

  • void Invoke(FFXIVClientStructs.FFXIV.Client.Graphics.Scene.Camera*, FFXIVClientStructs.FFXIV.Client.Graphics.Ray*, int, int)
  • void EndInvoke(System.IAsyncResult)

FFXIVClientStructs.FFXIV.Client.Graphics.Scene: 1

Camera: 1

  • void ScreenPointToRay(FFXIVClientStructs.FFXIV.Client.Graphics.Ray*, int, int)

FFXIVClientStructs.FFXIV.Client.System.String.Utf8String.Delegates: 1

SanitizeString: 2

  • void Invoke(FFXIVClientStructs.FFXIV.Client.System.String.Utf8String*, ushort, FFXIVClientStructs.FFXIV.Client.System.String.Utf8String*)
  • void EndInvoke(System.IAsyncResult)

FFXIVClientStructs.FFXIV.Client.System.String: 1

Utf8String: 1

  • void SanitizeString(ushort, FFXIVClientStructs.FFXIV.Client.System.String.Utf8String*)

FFXIVClientStructs.FFXIV.Client.UI.Misc.CharaViewPortrait.Delegates: 1

Ctor: 2

  • void Invoke(FFXIVClientStructs.FFXIV.Client.UI.Misc.CharaViewPortrait*)
  • void EndInvoke(System.IAsyncResult)

FFXIVClientStructs.FFXIV.Client.UI.Misc: 1

CharaViewPortrait: 2

  • FFXIVClientStructs.FFXIV.Client.UI.Misc.CharaViewPortrait* Create()
  • void Ctor()

Type has changed inheritance

Global: 1

  • FFXIVClientStructs.FFXIV.Client.UI.Misc.CharaViewPortrait does not implement interface FFXIVClientStructs.FFXIV.Client.System.Memory.ICreatable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change PR contains breaking changes and wont be merged before a new patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant