[Draft] Preliminary review of lanai code changes #1

aghaisas · 2021-01-27T07:32:00Z

No description provided.

Reviewed-by: lancea, joehw

Reviewed-by: zgu, iklam

…ng/plaf/nimbus/doc-files/properties.html Reviewed-by: serb, aivanov

kevinrushforth

I left a few inline comments. Here are a couple global ones:

Several files are missing copyright headers. I have scripts that will fix them, so I will volunteer to do that. I can update the copyright years to 2021 at the same time if there are no objections.
I see several files with wildcard imports. Do we want to eliminate (expand) these?

.jcheck/conf

src/java.desktop/macosx/classes/sun/java2d/metal/MTLBufImgOps.java

src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/EncoderManager.h

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/EncoderManager.m

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLUtils.m

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/RenderOptions.h

src/java.desktop/share/classes/javax/swing/RepaintManager.java

src/java.desktop/share/classes/sun/java2d/pipe/RenderBuffer.java

kevinrushforth · 2021-01-27T18:23:49Z

test/jdk/performance/client/RenderPerfTest/build.xml

+ PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
+ LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+ NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.


Question for Phil: is a BSD license OK for this build script? The rest of the files are GPL.

src/java.desktop/macosx/classes/sun/java2d/metal/MTLGraphicsConfig.java

src/java.desktop/macosx/classes/sun/java2d/metal/MTLLayer.java

src/java.desktop/macosx/classes/sun/java2d/metal/MTLSurfaceData.java

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.m

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLSurfaceData.m

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLSurfaceDataBase.h

src/java.desktop/share/classes/sun/java2d/pipe/BufferedPaints.java

Reviewed-by: dkonoplev

src/java.desktop/macosx/classes/sun/java2d/metal/MTLGraphicsConfig.java

src/java.desktop/macosx/classes/sun/lwawt/macosx/CWarningWindow.java

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.m

src/java.desktop/share/native/libawt/java2d/SurfaceData.c

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLRenderQueue.m

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLBlitLoops.m

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLContext.m

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.h

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLSurfaceData.m

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLContext.m

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.h

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.m

naotoj and others added 30 commits August 31, 2020 15:32

8252552: DecimalFormat javadoc contains HTML tags in example code

898c29f

Reviewed-by: lancea, joehw

Automatic merge of client:master into master

7bc7265

8252592: Non-PCH build is broken after JDK-8251560

b5a8079

Reviewed-by: zgu, iklam

8251122: doclint html5 errors in java.desktop/share/classes/javax/swi…

57bf93d

…ng/plaf/nimbus/doc-files/properties.html Reviewed-by: serb, aivanov

Automatic merge of client:master into master

7456072

Merge

b79f4f0

Automatic merge of client:master into master

a3d5998

8251032: Colors with texture background look different with Alpha Com…

bcc85aa

8252706: Enable usage of rowBytesOffset for LCD non cache rendering

d3bbb05

8252386: Lanai: Implement RadialGradientPaint in shader

db306e2

8252798: Cleanup LCD text rendering code

ab213f5

8252845: Regressions in Sanity tests after JDK-8251032

2c50c0f

8252949: Shape clip should use identity transform for drawing clip spans

6cecbed

8252895: Black background in SwingSet2 in Nimbus LAF

bcb31ed

Merge jdk:master

bfcf110

Automatic merge of jdk:master into master

4266479

Automatic merge of jdk:master into master

571e894

Automatic merge of jdk:master into master

9be2107

8252880: Image operations are not working with metal

272da50

Automatic merge of jdk:master into master

c9dcc4d

Automatic merge of jdk:master into master

23aeda1

Automatic merge of jdk:master into master

4a8f2d2

Automatic merge of jdk:master into master

389eab6

Automatic merge of jdk:master into master

e77f8f1

Automatic merge of jdk:master into master

f638c5b

Automatic merge of jdk:master into master

69bc41b

Automatic merge of jdk:master into master

994240f

Automatic merge of jdk:master into master

521ad85

Automatic merge of jdk:master into master

3f2cc91

Automatic merge of jdk:master into master

82e504b

kevinrushforth reviewed Jan 27, 2021

View reviewed changes

kevinrushforth and others added 2 commits January 27, 2021 21:30

8260554: Missing copyright headers on some Lanai files

10cabad

Automatic merge of jdk:master into master

710301d

mrserb suggested changes Jan 28, 2021

View reviewed changes

aghaisas and others added 3 commits January 28, 2021 10:10

8260578: Replace wildcard imports with specific ones

24f0d2a

8260582: Clean up MacOSFlags implementation

2a9fcc5

8260553: Lanai: pipeline substates use while loop for resize

88c1ff8

Reviewed-by: dkonoplev

mrserb reviewed Jan 28, 2021

View reviewed changes

src/java.desktop/macosx/classes/sun/java2d/metal/MTLGraphicsConfig.java Show resolved Hide resolved

mrserb reviewed Jan 28, 2021

View reviewed changes

src/java.desktop/macosx/classes/sun/java2d/metal/MTLGraphicsConfig.java Outdated Show resolved Hide resolved

mrserb reviewed Jan 28, 2021

View reviewed changes

src/java.desktop/macosx/classes/sun/java2d/metal/MTLGraphicsConfig.java Outdated Show resolved Hide resolved

src/java.desktop/macosx/classes/sun/lwawt/macosx/CWarningWindow.java Show resolved Hide resolved

mrserb reviewed Jan 28, 2021

View reviewed changes

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.m Show resolved Hide resolved

Automatic merge of jdk:master into master

1cc80db

jayathirthrao reviewed Jan 29, 2021

View reviewed changes

src/java.desktop/share/native/libawt/java2d/SurfaceData.c Outdated Show resolved Hide resolved

jayathirthrao reviewed Jan 29, 2021

View reviewed changes

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLRenderQueue.m Outdated Show resolved Hide resolved

jayathirthrao and others added 9 commits January 29, 2021 15:15

8260640: Cleanup dead code and comments imported from OpenGL

a6f59f9

8254868: Remove additional logging added under JDK-8229819

f4666a6

8260651: Build fails after fix for JDK-8260640

9890f08

Automatic merge of jdk:master into master

99b2ff5

8260672: Lanai: refactor MTLBlitLoops, MTLLayer, MTLSurfaceData

162fbcd

8260681: Lanai: Refactor MTLBlitLoops.m, common.h, shaders.metal

b8f99e1

Automatic merge of jdk:master into master

6a33829

Automatic merge of jdk:master into master

b64eb4e

8260706: Minor cleanup - CGLGraphicsConfig.java and MTLBlitLoops.m

6a4d695

avu approved these changes Feb 1, 2021

View reviewed changes

Alexey Ushakov and others added 6 commits February 1, 2021 13:48

8260711:

5aca2ac

8260857: Remove JNFWeakJObjectWrapper from Lanai Project

7bf226f

Automatic merge of jdk:master into master

5a3cc03

Automatic merge of jdk:master into master

30b87c9

Merge jdk:master

7b6b7be

8261134: Remove additional blank lines at EOF

81729ba

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Draft] Preliminary review of lanai code changes #1

[Draft] Preliminary review of lanai code changes #1

aghaisas commented Jan 27, 2021

kevinrushforth left a comment

kevinrushforth Jan 27, 2021

[Draft] Preliminary review of lanai code changes #1

Are you sure you want to change the base?

[Draft] Preliminary review of lanai code changes #1

Conversation

aghaisas commented Jan 27, 2021

kevinrushforth left a comment

Choose a reason for hiding this comment

kevinrushforth Jan 27, 2021

Choose a reason for hiding this comment