Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting up app - renamed app #21

Merged
merged 10 commits into from
Nov 6, 2017
Merged

Conversation

beaesguerra
Copy link
Contributor

Re-submitting a pull request to initalize the app with a different name (agritrader).
Original pull request: #19

Many of the files were generated when the react native project was initialized.

Main changes:

  • Set up the mobile app using react native
  • Integrated typescript
  • Include readme for set up instructions
  • Set up code coverage thresholds
  • See package.json, README.md, and tsconfig.json

Sample screenshot of the application in its' basic state:
image

@beaesguerra
Copy link
Contributor Author

The android & ios folders are included for when we want to add native code for the app (which we probably won't need, but having them available will give us the opportunity to use them if needed).

Also, the react native project initializer generated a proper gitignore and these folders were not specified to be ignored.

@beaesguerra
Copy link
Contributor Author

I also lowered the code coverage threshold so it is not misleading

@ExtraGravity ExtraGravity self-assigned this Nov 3, 2017
@jeinglis
Copy link
Contributor

jeinglis commented Nov 6, 2017

Looks good although it took me a long time to get all my env variables set up so that it will launch (i didn't see the other tab that told you how to do it all) had to set ANDROID_HOME ---> android sdk and add adb.exe to my path. I think you should add these to the readme to make it easier for the others

@beaesguerra
Copy link
Contributor Author

@jeinglis updated the readme to include instructions on how to set up your device along with common issues and how to solve them

@beaesguerra beaesguerra merged commit ffca3a7 into master Nov 6, 2017
@Parasrah Parasrah deleted the beaesguerra/AT-12/setting-up-app branch January 15, 2018 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants