feat: fix deleted value test

wrong specification
agritheory · Aug 4, 2024 · fc27225 · fc27225
1 parent b7fddc2
commit fc27225
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 10 deletions.
diff --git a/inventory_tools/inventory_tools/doctype/specification/specification.py b/inventory_tools/inventory_tools/doctype/specification/specification.py
@@ -175,9 +175,9 @@ def get_applicable_specification(doc):
 
 @frappe.whitelist()
 def get_specification_values(reference_doctype, reference_name, specification=None):
+	_r = []
 	if not specification:
 		specs = get_applicable_specification(frappe.get_doc(reference_doctype, reference_name))
-		_r = []
 	else:
 		specs = [specification]
 	for s in specs:

diff --git a/inventory_tools/tests/setup.py b/inventory_tools/tests/setup.py
@@ -826,6 +826,10 @@ def create_specifications(settings=None):
 
 
 def create_demo_specification_values():
+	"""
+	run this if you need to manually create data for demoing faceted search
+	bench execute 'inventory_tools.tests.setup.create_demo_specification_values'
+	"""
 	from inventory_tools.tests.test_faceted_search import (
 		test_values_updated_on_item_save,
 		test_generate_values,

diff --git a/inventory_tools/tests/test_faceted_search.py b/inventory_tools/tests/test_faceted_search.py
@@ -118,7 +118,8 @@ def test_manual_attribute_addition():
 		_args = {
 			"reference_doctype": "Item",
 			"reference_name": item,
-			"specification": "Baked Goods",
+			"specification": "Items",
+
 		}
 		values = frappe.call(
 			"inventory_tools.inventory_tools.doctype.specification.specification.get_specification_values",
@@ -128,20 +129,20 @@ def test_manual_attribute_addition():
 			if isinstance(manual_values, list):
 				for v in manual_values:
 					values.append(
-						{"row_name": "", "attribute": attribute, "value": v, "specification": "Baked Goods"}
+						{"row_name": "", "attribute": attribute, "value": v, "specification": "Items"}
 					)
 			else:
 				values.append(
 					{
 						"row_name": "",
 						"attribute": attribute,
 						"value": manual_values,
-						"specification": "Baked Goods",
+						"specification": "Items",
 					}
 				)
 		# print(existing_values)
 		args = {
-			"spec": "Baked Goods",
+			"spec": "Items",
 			"specifications": frappe.as_json(values),
 			"reference_doctype": "Item",
 			"reference_name": item,
@@ -152,7 +153,7 @@ def test_manual_attribute_addition():
 		)
 	assert (
 		len(
-			frappe.get_all("Specification Value", {"specification": "Baked Goods", "attribute": "Color"})
+			frappe.get_all("Specification Value", {"specification": "Items", "attribute": "Color"})
 		)
 		== 25
 	)  # all colors in baked goods items from fixtures
@@ -164,14 +165,15 @@ def test_delete_of_specification_value():
 	_args = {
 		"reference_doctype": "Item",
 		"reference_name": "Ambrosia Pie",
-		"specification": "Baked Goods",
+		"specification": "Items",
 	}
 	values = frappe.call(
 		"inventory_tools.inventory_tools.doctype.specification.specification.get_specification_values",
 		**_args
 	)
-	assert "Blue" in [v.value for v in values if v.attribute == "Color"]
-	assert len(values) == 11
+	colors = [v.value for v in values if v.attribute == "Color"]
+	assert "Blue" in colors
+	assert len(colors) == 2
 
 	for v in values:
 		if v.attribute == "Color" and v.value == "Blue":
@@ -192,7 +194,7 @@ def test_delete_of_specification_value():
 			frappe.get_all(
 				"Specification Value",
 				{
-					"specification": "Baked Goods",
+					"specification": "Items",
 					"attribute": "Color",
 					"reference_name": _args.get("reference_name"),
 				},