Add an ending newline to generated files

ahamez · Mar 2, 2022 · b10318f · b10318f
1 parent 6121a92
commit b10318f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/lib/protox/generate.ex b/lib/protox/generate.ex
@@ -61,18 +61,10 @@ defmodule Protox.Generate do
   end
 
   defp generate_file_content(code) do
-    code_str = Macro.to_string(code)
-
-    formatted_code =
-      try do
-        Code.format_string!(code_str)
-      rescue
-        _ -> code_str
-      end
-
     [
       "# credo:disable-for-this-file\n",
-      formatted_code
+      code |> Macro.to_string() |> Code.format_string!(),
+      "\n"
     ]
   end
 end
diff --git a/test/code_generation_test.exs b/test/code_generation_test.exs
@@ -145,6 +145,18 @@ defmodule Protox.CodeGenerationTest do
       )
 
     assert credo_exit_status == 0
+
+    {_, mix_format_exit_status} =
+      System.cmd(
+        "mix",
+        [
+          "format",
+          "--check-formatted"
+        ],
+        cd: code_generation_path
+      )
+
+    assert mix_format_exit_status == 0
   end
 
   defp mix_exs() do