Remove the sketchy t.Fatal calls under synctest

ahamlinman · Feb 19, 2025 · 8ee8b93 · 8ee8b93
1 parent b31644b
commit 8ee8b93
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/internal/watch/watch_synctest_test.go b/internal/watch/watch_synctest_test.go
@@ -67,7 +67,8 @@ func TestWaitSynctest(t *testing.T) {
 		synctest.Wait()
 		select {
 		case <-done:
-			t.Fatal("watcher finished waiting before cancellation") // Sketchy; not in the test goroutine
+			t.Error("watcher finished waiting before cancellation")
+			return
 		default:
 		}
 
@@ -76,7 +77,8 @@ func TestWaitSynctest(t *testing.T) {
 		synctest.Wait()
 		select {
 		case <-done:
-			t.Fatal("watcher finished waiting before handler exit") // Sketchy; not in the test goroutine
+			t.Error("watcher finished waiting before handler exit")
+			return
 		default:
 		}