Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate most shortcut keys to command+? on Mac #366

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Migrate most shortcut keys to command+? on Mac #366

merged 4 commits into from
Jul 10, 2023

Conversation

qcgm1978
Copy link
Contributor

@qcgm1978 qcgm1978 commented Jul 8, 2023

@vercel
Copy link

vercel bot commented Jul 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chatall ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 2:01am

@sunner
Copy link
Member

sunner commented Jul 8, 2023

Good job @qcgm1978. Finally you find the way to support command key on macOS. But as @tanchekwei commended, the simple modification breaks things. Could you give it a try to use command for all the shortcuts and make everything well? Thank you.

sunner
sunner requested changes Jul 9, 2023
View reviewed changes
Copy link
Member

@sunner sunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. Just a little more work to do to make the code more readable. Thank you!

src/components/ShortcutGuide/ShortcutGuide.vue Outdated Show resolved Hide resolved
src/App.vue Show resolved Hide resolved
src/components/ShortcutGuide/shortcut.const.js Outdated Show resolved Hide resolved
src/components/ShortcutGuide/shortcut.const.js Outdated Show resolved Hide resolved
src/components/ShortcutGuide/ShortcutGuide.vue Outdated Show resolved Hide resolved
sunner
sunner requested changes Jul 10, 2023
View reviewed changes
Copy link
Member

@sunner sunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove .once is acceptable for me. @tanchekwei do you have any concern?

src/components/ShortcutGuide/ShortcutGuide.vue Outdated Show resolved Hide resolved
@tanchekwei
Copy link
Contributor

Remove .once is acceptable for me. @tanchekwei do you have any concern?

No concern for me as well.

@qcgm1978 qcgm1978 requested a review from sunner July 10, 2023 02:06
@sunner sunner changed the title Find shortcut keys that support command+f on Mac Migrate most shortcut keys to command+? on Mac Jul 10, 2023
@sunner sunner merged commit a88e84c into ai-shifu:main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanchekwei tanchekwei tanchekwei left review comments

@sunner sunner Awaiting requested review from sunner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qcgm1978 @sunner @tanchekwei