-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify structure operations #666
Clarify structure operations #666
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #666 +/- ##
=======================================
Coverage 83.41% 83.41%
=======================================
Files 17 17
Lines 3581 3581
=======================================
Hits 2987 2987
Misses 594 594
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
51a2571
to
fedfe7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I wonder thy now more tests are failing |
Hmm, that's very odd indeed. Not sure what the COD database has to do with this PR. Will check before merging. |
That particular test is flaky, reported in #649. It needs to be refactored because it accesses the live COD database. Instead the DB access needs to be mocked out. |
Thanks @danielhollas. Forgot I even opened that one. Too many issues/PRs! Indeed, a simple re-run was sufficient. |
This PR aims to emphasize the distinction between visualizing the super cell and actually transforming it. It does so by (i) wrapping the viewer in its own accordion titled "View structure", and (ii) adding a comment below the super cell control in the appearance tab of the viewer clarifying usage.
Closes #667