Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify structure operations #666

Merged

Conversation

edan-bainglass
Copy link
Member

@edan-bainglass edan-bainglass commented Jan 30, 2025

This PR aims to emphasize the distinction between visualizing the super cell and actually transforming it. It does so by (i) wrapping the viewer in its own accordion titled "View structure", and (ii) adding a comment below the super cell control in the appearance tab of the viewer clarifying usage.

Closes #667

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.41%. Comparing base (0aaf8fe) to head (3353ddb).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #666   +/-   ##
=======================================
  Coverage   83.41%   83.41%           
=======================================
  Files          17       17           
  Lines        3581     3581           
=======================================
  Hits         2987     2987           
  Misses        594      594           
Flag Coverage Δ
python-3.11 83.41% <100.00%> (ø)
python-3.9 83.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edan-bainglass edan-bainglass force-pushed the clear-structure-operations branch from 51a2571 to fedfe7a Compare January 30, 2025 08:41
Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndresOrtegaGuerrero
Copy link
Member

I wonder thy now more tests are failing

@edan-bainglass
Copy link
Member Author

I wonder thy now more tests are failing

Hmm, that's very odd indeed. Not sure what the COD database has to do with this PR. Will check before merging.

@danielhollas
Copy link
Contributor

That particular test is flaky, reported in #649. It needs to be refactored because it accesses the live COD database. Instead the DB access needs to be mocked out.

@edan-bainglass
Copy link
Member Author

That particular test is flaky, reported in #649. It needs to be refactored because it accesses the live COD database. Instead the DB access needs to be mocked out.

Thanks @danielhollas. Forgot I even opened that one. Too many issues/PRs! Indeed, a simple re-run was sufficient.

@edan-bainglass edan-bainglass merged commit 3f2626f into aiidalab:master Jan 30, 2025
9 of 11 checks passed
@danielhollas danielhollas added the enhancement New feature or request label Feb 7, 2025
edan-bainglass added a commit that referenced this pull request Feb 12, 2025
Following #666, I make structure selection consistent with viewing and editing, as well as guard against no importers following #681.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusion between structure visualization and structure editing
3 participants