Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing to aiida/common/{utils,extendeddicts}.py #6706

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

danielhollas
Copy link
Collaborator

@danielhollas danielhollas commented Jan 14, 2025

This completes the typing of the aiida.common module.

The types in extendeddicts.py is kind of shoddy, and some function signatures are not typed since all the classes there are super-generic so they would all be mostly Any anyway. But I think it is still better than nothing and it is better than ignoring this file entirely.

Depends on #6704

@danielhollas danielhollas marked this pull request as draft January 14, 2025 18:55
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 84.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.00%. Comparing base (199a027) to head (55d03cd).

Files with missing lines Patch % Lines
src/aiida/common/utils.py 89.66% 3 Missing ⚠️
src/aiida/orm/computers.py 50.00% 3 Missing ⚠️
src/aiida/orm/comments.py 33.34% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6706      +/-   ##
==========================================
+ Coverage   77.99%   78.00%   +0.01%     
==========================================
  Files         563      563              
  Lines       41762    41765       +3     
==========================================
+ Hits        32570    32573       +3     
  Misses       9192     9192              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant