Q2rCalculation: Add the output_parameters output to the spec
#974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Q2rCalculation` did not declare the `output_parameters` output even though the `Q2rParser` attaches it always. This would lead to the calculation excepting because an unknown output would be attached. This was uncaught by the test because the `Parser.parse_from_node` method does not automatically validate the outputs. This is because the output spec that is checked is that of the `calcfunction` (which accepts anything) and not that of the `Q2rCalculation`.
sphuber
force-pushed
the
fix/971/q2r-output-parameters
branch
from
a0e273c to
04f3fba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #971
The
Q2rCalculationdid not declare theoutput_parametersoutput even though theQ2rParserattaches it always. This would lead to the calculation excepting because an unknown output would be attached. This was uncaught by the test because theParser.parse_from_nodemethod does not automatically validate the outputs. This is because the output spec that is checked is that of thecalcfunction(which accepts anything) and not that of theQ2rCalculation.